This is a clean up of the patch initially suggested for resolving issue #253. I've also added a simple test to make sure the option behaves as expected.
Thanks for the patch - it looks like your attempt to fix pypy is still causing failing tests
Does this pass for you locally?
that 1 pypy test has been failing periodically in the develop branch as well.
trying to sort out here: #698
Yep, this doesn't seem to be related to my changes. Judging by the activity on pull request #698 this seems to have been resolved now?
Is there any way to tell Travis to re-run the test on my pull request changes to confirm it's all working now? Thanks.
you'd need to merge or rebase on develop to get that test fix I made in #698
afaik, you can only trigger travis based on branch changes. a "redo" button would be nice.
Added --root command line option, works the same as for distutils
Simple test to check --root option functionality
PyPy is special and overrides default distutils directory scheme, alt…
…er test to suit
Ok, thanks, rebased. The pull request should be good to go now.
Looks great - do you want to add yourself to AUTHORS.txt if not present and update docs/news.txt and I'll merge.
Sorry about the delayed reply, I hadn't realised where the message notification had been moved to on Github most recently.
No problems I'll do that. One question because I'm not sure how this is usually done. Would you prefer if I squash all the changes in my pull request into a single commit? Or do you prefer to keep a more fine grained history? Or is all the squashing something that happens automatically when you do the merging anyway?
we don't require the commits to be squashed. you can just leave it as is. github merging doesn't squash.
Added author name and description of changes
Alright I've updated those two files so it should be ready to go.
the test for this is failing on windows:
Hi, is this still an issue? The link you gave doesn't seem to go anywhere.
the test is working now on linux and windows with a minor change.
can you confirm the test still looks valid to you?
the change is in this diff: 6b5fd90
Hi, I've made the test a little better so that it works correctly for the special case where it is most useful. It's in pull request #787. Turns out Python's distutils simply doesn't allow unix style root paths to be specified under windows for an installation.