Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin splitting handling of legacy and modern source distributions #6990

Conversation

@pradyunsg
Copy link
Member

pradyunsg commented Sep 7, 2019

This PR initiates the work for separating code paths for handling legacy and source distributions. I'm gonna start by duplicating code between them and then changing which methods they call on InstallRequirement as we go ahead. This will be what follow-up PRs to this, will tackle. :)

This also moves code for build isolation into a dedicated method, that only exists on the ModernSourceDistribution.

pradyunsg added 7 commits Sep 7, 2019
@pradyunsg pradyunsg added this to In progress in Build Logic Refactor via automation Sep 7, 2019
@pradyunsg

This comment has been minimized.

Copy link
Member Author

pradyunsg commented Sep 7, 2019

Oh right. We're isolating w/o PEP 517 as well. :(

@pradyunsg pradyunsg closed this Sep 7, 2019
Build Logic Refactor automation moved this from In progress to Done Sep 7, 2019
@pradyunsg pradyunsg deleted the pradyunsg:refactor/separate-legacy-and-modern-sdist branch Oct 6, 2019
@lock lock bot added the S: auto-locked label Nov 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
You can’t perform that action at this time.