New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put back finder link priority (with tests) #702

Merged
merged 3 commits into from Oct 25, 2012

Conversation

Projects
None yet
2 participants
@qwcode
Contributor

qwcode commented Oct 11, 2012

In pull #683, I made a fix so that the package finder preferred the existing installation over found file:// links. (w/o this upgrades would occur with file:// find-links despite having the best version installed)

the problem with that fix is that it broke the link prioritization jannis put in place 3 years ago.
62df4c2

this pull unbreaks the priority logic (with 3 new tests), while also fixing the file:// link upgrade problem (which has tests already from the previous pull) in a different way .

Considering that "Inf" is not used as a sortable anymore, I opened #703 to consider dropping it's use.

@qwcode qwcode closed this Oct 11, 2012

@qwcode qwcode reopened this Oct 14, 2012

pnasrat added a commit that referenced this pull request Oct 25, 2012

Merge pull request #702 from qwcode/link_sort2
put back finder link priority (with tests)

@pnasrat pnasrat merged commit 32f0be7 into pypa:develop Oct 25, 2012

1 check passed

default The Travis build passed
Details

@qwcode qwcode referenced this pull request Nov 26, 2012

Closed

Support index preference. #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment