Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manylinux2014 support #7102

Merged
merged 2 commits into from Oct 10, 2019
Merged

Add manylinux2014 support #7102

merged 2 commits into from Oct 10, 2019

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Sep 28, 2019

@mayeut mayeut force-pushed the manylinux2014 branch 3 times, most recently from 62f0b12 to 91c6dec Compare Sep 28, 2019
@mayeut mayeut changed the title Add manylinux2014 support WIP - Add manylinux2014 support Sep 28, 2019
@mayeut
Copy link
Member Author

@mayeut mayeut commented Sep 28, 2019

This PR mostly extend what was done for manylinux2010
Given what's proposed to replace pep425tags, I've not spent time trying to refactor much.
c.f. also Tracking issue for manylinux2014 rollout

@mayeut mayeut changed the title WIP - Add manylinux2014 support Add manylinux2014 support Sep 28, 2019
src/pip/_internal/pep425tags.py Outdated Show resolved Hide resolved
@xavfernandez xavfernandez mentioned this pull request Sep 30, 2019
@mayeut
Copy link
Member Author

@mayeut mayeut commented Oct 1, 2019

@di, as author of the PEP, you might want to check on this. I didn't get a chance to comment on the PEP PR regarding ABI compatibility of armv7l before it was merged in.

@mayeut
Copy link
Member Author

@mayeut mayeut commented Oct 2, 2019

The last commit shall address ABI concerns wit linux armv7l

di
di approved these changes Oct 9, 2019
Copy link
Sponsor Member

@di di left a comment

Can we make sure to backport (forwardport?) the armhf detection to packaging.tags as well?

news/7102.feature Outdated Show resolved Hide resolved
Copy link
Member

@chrahunt chrahunt left a comment

One cosmetic issue, otherwise LGTM.

tests/unit/test_pep425tags.py Outdated Show resolved Hide resolved
@mayeut
Copy link
Member Author

@mayeut mayeut commented Oct 9, 2019

Can we make sure to backport (forwardport?) the armhf detection to packaging.tags as well?

I forked packaging yesterday and I'm looking at this (along with x32)

mayeut added 2 commits Oct 9, 2019
PEP 599 defines manylinux2014 armv7l to be compatible with centos7 altarch armv7 i.e. armhf using the gnueabihf ABI
@xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Oct 10, 2019

Is there any reason this isn't merged ? It seems OK to me :)

@chrahunt
Copy link
Member

@chrahunt chrahunt commented Oct 10, 2019

I don't think so! Nothing is outstanding so I'll merge it.

@chrahunt chrahunt merged commit f3f396f into pypa:master Oct 10, 2019
24 checks passed
@mayeut mayeut deleted the manylinux2014 branch Oct 11, 2019
@lock lock bot added the auto-locked label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants