Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manylinux2014 support #7102

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@mayeut
Copy link
Contributor

mayeut commented Sep 28, 2019

@mayeut mayeut force-pushed the mayeut:manylinux2014 branch 3 times, most recently from 62f0b12 to 91c6dec Sep 28, 2019
@mayeut mayeut changed the title Add manylinux2014 support WIP - Add manylinux2014 support Sep 28, 2019
@mayeut

This comment has been minimized.

Copy link
Contributor Author

mayeut commented Sep 28, 2019

This PR mostly extend what was done for manylinux2010
Given what's proposed to replace pep425tags, I've not spent time trying to refactor much.
c.f. also Tracking issue for manylinux2014 rollout

@mayeut mayeut changed the title WIP - Add manylinux2014 support Add manylinux2014 support Sep 28, 2019
@xavfernandez xavfernandez referenced this pull request Sep 30, 2019
@mayeut

This comment has been minimized.

Copy link
Contributor Author

mayeut commented Oct 1, 2019

@di, as author of the PEP, you might want to check on this. I didn't get a chance to comment on the PEP PR regarding ABI compatibility of armv7l before it was merged in.

@mayeut mayeut force-pushed the mayeut:manylinux2014 branch from cbffda2 to f6e5580 Oct 2, 2019
@mayeut

This comment has been minimized.

Copy link
Contributor Author

mayeut commented Oct 2, 2019

The last commit shall address ABI concerns wit linux armv7l

@brainwane brainwane referenced this pull request Oct 7, 2019
13 of 26 tasks complete
@xavfernandez xavfernandez added this to the 19.3 milestone Oct 7, 2019
@di
di approved these changes Oct 9, 2019
Copy link
Member

di left a comment

Can we make sure to backport (forwardport?) the armhf detection to packaging.tags as well?

news/7102.feature Outdated Show resolved Hide resolved
Copy link
Member

chrahunt left a comment

One cosmetic issue, otherwise LGTM.

tests/unit/test_pep425tags.py Outdated Show resolved Hide resolved
@mayeut

This comment has been minimized.

Copy link
Contributor Author

mayeut commented Oct 9, 2019

Can we make sure to backport (forwardport?) the armhf detection to packaging.tags as well?

I forked packaging yesterday and I'm looking at this (along with x32)

mayeut added 2 commits Sep 25, 2019
PEP 599 defines manylinux2014 armv7l to be compatible with centos7 altarch armv7 i.e. armhf using the gnueabihf ABI
@mayeut mayeut force-pushed the mayeut:manylinux2014 branch from f6e5580 to d3d3cca Oct 9, 2019
@xavfernandez

This comment has been minimized.

Copy link
Contributor

xavfernandez commented Oct 10, 2019

Is there any reason this isn't merged ? It seems OK to me :)

@chrahunt

This comment has been minimized.

Copy link
Member

chrahunt commented Oct 10, 2019

I don't think so! Nothing is outstanding so I'll merge it.

@chrahunt chrahunt merged commit f3f396f into pypa:master Oct 10, 2019
24 checks passed
24 checks passed
🤖 (ubuntu-18.04, docs) 🤖 (ubuntu-18.04, docs)
Details
🤖 (ubuntu-18.04, lint) 🤖 (ubuntu-18.04, lint)
Details
Linux Build #20191009.11 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20191009.11 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x86) Test Primary Python27-x86 succeeded
Details
Windows (Test Primary Python37-x64) Test Primary Python37-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20191009.11 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@mayeut mayeut deleted the mayeut:manylinux2014 branch Oct 11, 2019
@lock lock bot added the S: auto-locked label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.