Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crash when `sys.stdin` is `None` #7118
Can you please create an issue instead, providing the relevant details and ideally a way to easily reproduce this? As it stands it's very difficult to evaluate this change, and without understanding or tests it would be even harder to prevent a regression in the future.
I'm new to the project code layout, but I can give it a go. :)
I have one uncertainty though: do we want to have the new interactivity check function in the
Or, because it's so generic, would it be better placed somewhere in a "higher" class? (where?)
Thanks for the update.
I would add a helper function and two tests in
The function would take a
The first test would call the helper function then make sure that
The second (maybe
That ensures that we're always testing the situation that would succeed except for the other changes we make for the failure test cases - this will help a lot with the other change mentioned in #7042 later.