Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running svn tests when svn isn't installed #7193

Merged
merged 3 commits into from Oct 15, 2019
Merged

Conversation

@vharsh
Copy link
Contributor

vharsh commented Oct 14, 2019

Signed-off-by: Harsh Vardhan harsh59v@gmail.com

NOTE to maintainers:

  1. I'll also be pushing a similar fix for skipping svnadmin (If it's okay to send it in the same PR, with a modified description)
    [Update] Maybe it requires a separate discussion, not sure if svn client and svnadmin should be treated separately
    2. I'll push the NEWS changes soon
@vharsh vharsh force-pushed the vharsh:skip_svn_test branch 2 times, most recently from eca5e7e to 629495f Oct 14, 2019
vharsh added 2 commits Oct 14, 2019
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
@vharsh vharsh force-pushed the vharsh:skip_svn_test branch from 629495f to 2f1a419 Oct 14, 2019
@vharsh vharsh marked this pull request as ready for review Oct 14, 2019
@vharsh vharsh force-pushed the vharsh:skip_svn_test branch from 7d7ec1d to 6b60029 Oct 14, 2019
Copy link
Member

pradyunsg left a comment

LGTM. Just need us to make sure that we stop directly using the pytest.mark.svn.

tests/unit/test_vcs.py Outdated Show resolved Hide resolved
tests/functional/test_uninstall.py Outdated Show resolved Hide resolved
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
@vharsh vharsh force-pushed the vharsh:skip_svn_test branch from 6b60029 to 0e6ac42 Oct 15, 2019
@chrahunt chrahunt merged commit bc7948e into pypa:master Oct 15, 2019
24 checks passed
24 checks passed
🤖 (ubuntu-18.04, docs)
Details
🤖 (ubuntu-18.04, lint)
Details
Linux Build #20191015.16 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20191015.16 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x86) Test Primary Python27-x86 succeeded
Details
Windows (Test Primary Python37-x64) Test Primary Python37-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20191015.16 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@vharsh vharsh deleted the vharsh:skip_svn_test branch Oct 17, 2019
@lock lock bot added the S: auto-locked label Nov 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.