Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running svn tests when svn isn't installed

Merged
merged 3 commits into from Oct 15, 2019

Conversation

vharsh
Copy link
Contributor

@vharsh vharsh commented Oct 14, 2019

Signed-off-by: Harsh Vardhan harsh59v@gmail.com

NOTE to maintainers:

  1. I'll also be pushing a similar fix for skipping svnadmin (If it's okay to send it in the same PR, with a modified description)
    [Update] Maybe it requires a separate discussion, not sure if svn client and svnadmin should be treated separately
    2. I'll push the NEWS changes soon

@vharsh vharsh force-pushed the skip_svn_test branch 2 times, most recently from eca5e7e to 629495f Compare Oct 14, 2019
vharsh added 2 commits Oct 14, 2019
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
@vharsh vharsh marked this pull request as ready for review Oct 14, 2019
Copy link
Member

@pradyunsg pradyunsg left a comment

LGTM. Just need us to make sure that we stop directly using the pytest.mark.svn.

tests/unit/test_vcs.py Outdated Show resolved Hide resolved
tests/functional/test_uninstall.py Outdated Show resolved Hide resolved
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
@chrahunt chrahunt merged commit bc7948e into pypa:master Oct 15, 2019
24 checks passed
@vharsh vharsh deleted the skip_svn_test branch Oct 17, 2019
@lock lock bot added the auto-locked label Nov 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants