Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe basic auth credentials in documentation #7201

Merged
merged 13 commits into from Nov 13, 2019

Conversation

@aniruddha2000
Copy link
Contributor

aniruddha2000 commented Oct 14, 2019

No description provided.

docs/html/user_guide.rst Outdated Show resolved Hide resolved
Copy link
Member

chrahunt left a comment

A few examples would be good too. At least one with some special characters that need to be percent-encoded and one using a single-part login token (like 0123456789abcdef@example.com, representing an auth token).

docs/html/user_guide.rst Outdated Show resolved Hide resolved
news/7201.doc Outdated Show resolved Hide resolved
@pradyunsg pradyunsg requested a review from chrahunt Oct 21, 2019
Copy link
Member

chrahunt left a comment

In general I think we need to be much more verbose. The purpose is to replace all of the ad-hoc documentation that companies and enterprise repository providers are having to maintain, so it should cover each use case in a way that anyone could understand.

docs/html/user_guide.rst Outdated Show resolved Hide resolved
docs/html/user_guide.rst Outdated Show resolved Hide resolved
docs/html/user_guide.rst Outdated Show resolved Hide resolved
docs/html/user_guide.rst Outdated Show resolved Hide resolved
@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Nov 1, 2019

Pinging @chrahunt since I think this is awaiting his review.

@chrahunt

This comment has been minimized.

Copy link
Member

chrahunt commented Nov 9, 2019

Sorry I forgot about this, I have replied to the two pending comments.

docs/html/user_guide.rst Outdated Show resolved Hide resolved
… older Pythons and pips
docs/html/user_guide.rst Outdated Show resolved Hide resolved
Copy link
Member

chrahunt left a comment

Last comment, otherwise LGTM.

docs/html/user_guide.rst Outdated Show resolved Hide resolved
docs/html/user_guide.rst Outdated Show resolved Hide resolved
Copy link
Member

chrahunt left a comment

I fixed that last nitpick.

@chrahunt chrahunt merged commit 4c1a7cd into pypa:master Nov 13, 2019
26 checks passed
26 checks passed
🤖 (ubuntu-18.04, docs)
Details
🤖 (ubuntu-18.04, lint)
Details
Linux Build #20191112.14 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20191112.14 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x86) Test Primary Python27-x86 succeeded
Details
Windows (Test Primary Python35-x64) Test Primary Python35-x64 succeeded
Details
Windows (Test Primary Python37-x64) Test Primary Python37-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20191112.14 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@chrahunt

This comment has been minimized.

Copy link
Member

chrahunt commented Nov 13, 2019

Thanks for sticking with this @aniruddha2000! I think it will help a lot of people. :)

@aniruddha2000

This comment has been minimized.

Copy link
Contributor Author

aniruddha2000 commented Nov 13, 2019

Thanks @chrahunt , @pradyunsg for guiding me in this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.