Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Python 3.8 #7219

Merged
merged 2 commits into from Oct 17, 2019
Merged

Declare support for Python 3.8 #7219

merged 2 commits into from Oct 17, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 15, 2019

No description provided.

@pradyunsg pradyunsg added the type: maintenance label Oct 15, 2019
@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Oct 15, 2019

Thanks for filing this @hugovk!

Could you:

  • update docs/html/installing.rst:112 for Python 3.8?

  • add news/7219.feature with the following content?

    Document Python 3.8 support.
    

We'd also want to add it to CI as well (in a follow up PR).

@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Oct 15, 2019

Updated!

About adding it to CI:

  • The Travis CI config is already testing 3.8-dev, currently Python 3.8.0rc1+, pretty much the same thing as 3.8.0 final. That could be moved further up, but I expect Travis will add 3.8.0 soon.

  • AppVeyor are adding it in their next images update: appveyor/ci#3142

  • Azure Pipelines: I've not checked it yet

@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Oct 16, 2019

  • Azure Pipelines: I've not checked it yet

Tracking issue: https://github.com/microsoft/azure-pipelines-image-generation/issues/1317

@chrahunt
Copy link
Member

@chrahunt chrahunt commented Oct 17, 2019

@hugovk, can you please file an issue that we can use as a checklist for 3.8 CI updates? Essentially containing the info from your comment above and linking to the tracking issues and our own PR(s).

@hugovk hugovk mentioned this pull request Oct 17, 2019
5 tasks
@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Oct 17, 2019

Sure, please see issue #7229.

@chrahunt
Copy link
Member

@chrahunt chrahunt commented Oct 17, 2019

Perfect, thank you!

@chrahunt chrahunt merged commit fde92e7 into pypa:master Oct 17, 2019
24 checks passed
@hugovk hugovk deleted the add-3.8 branch Oct 17, 2019
@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Oct 17, 2019

Awesome stuff! Thank you so much @hugovk!

Thanks for reviewing and merging this @chrahunt!

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Oct 17, 2019

@xavfernandez this is an RM decision but I forgot to flag it to you before the release -- 3.8.0 release was basically in sync with pip 19.3, and I think we should have a pip release (19.3.1?) that has support for it explicitly declared.

@pradyunsg pradyunsg mentioned this pull request Oct 17, 2019
xavfernandez pushed a commit to xavfernandez/pip that referenced this issue Oct 17, 2019
Declare support for Python 3.8
@xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Oct 17, 2019

Without a bugfix, I don't think I would have bothered but #6606 is a good reason :)

@lock lock bot added the auto-locked label Nov 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked type: maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants