Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interpreter-specific major version tag

Merged
merged 2 commits into from Nov 16, 2019

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Nov 15, 2019

As mentioned in https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/
this tag doesn't make much sense + it impedes our usage of
packaging.tags.

In terms of backwards-compatibility, we attest to try to match
compatible wheels as best as possible, and this tag doesn't represent
that.

See also pypa/packaging#187 (comment).

Progresses #6908.

As mentioned in https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/
this tag doesn't make much sense + it impedes our usage of
packaging.tags.

In terms of backwards-compatibility, we attest to try to match
compatible wheels as best as possible, and this tag doesn't represent
that.
@chrahunt chrahunt added type: refactor skip news labels Nov 15, 2019
@chrahunt chrahunt marked this pull request as ready for review Nov 15, 2019
@pradyunsg pradyunsg removed the skip news label Nov 15, 2019
@pradyunsg
Copy link
Member

pradyunsg commented Nov 15, 2019

Sounds like a good idea to me.

This is a minor removal that's not documented, so I don't think there's any good case to do a deprecation cycle here, yes, but this is still a change in user-facing behavior and I think calling it out in our NEWS would be a good way to minimally communicate this change.

IMO we should mention this change in a .removal NEWS fragment, noting why we didn't have a deprecation cycle (not documented + link to Brett's post) and how, if someone is really interested in us keeping this functionality, to advocate for adding this back (file an issue on packaging).

@chrahunt
Copy link
Member Author

chrahunt commented Nov 16, 2019

Added removal news.

@chrahunt chrahunt merged commit 4447cb0 into pypa:master Nov 16, 2019
26 checks passed
@chrahunt
Copy link
Member Author

chrahunt commented Nov 16, 2019

Thanks @pradyunsg for the comment and @xavfernandez for the review!

@chrahunt chrahunt deleted the refactor/remove-unnecessary-tag branch Nov 16, 2019
@lock lock bot added the auto-locked label Dec 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants