-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building packages with backend-path in pyproject.toml #7394
Conversation
Would this be a good chance to refactor the return value into a named tuple? An optional two-tuple is kind of OK, but I’m starting to feel a tiny bit uncomfortable to read |
Sounds reasonable. Shall I call it |
I’m thinking |
Was detail (singular) a deliberate change? I was following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. I think it's okay that we're leaning a bit on pep517 for the more thorough testing of this feature, but I would add an integration test or two (for a local project using backend-path
and a dependency) since there's going to be a lot of change in the coming months in InstallRequirement
.
I added a test which uses a local backend and an external dependency together. |
For the additional test I was thinking more along the lines of invoking This helps us guard against regressions caused anywhere else in the currently tangled interactions between |
I've added a higher-level test as @chrahunt requested, but I've left the namedtuple in place for the moment. I'll change it again if it looks like there's a consensus for another option. |
Thanks for addressing this issue @takluyver! |
All that's needed is passing the field from
pyproject.toml
through toPep517HookCaller
.Closes gh-6599