/tmp/pip-build fixes (revisions to pull #734) #779

Merged
merged 19 commits into from Jan 26, 2013

Projects

None yet

2 participants

@qwcode
Collaborator
qwcode commented Jan 26, 2013

a few fixes on top of pull #734, mainly to get the tests to pass on windows

d1b and others added some commits Nov 23, 2012
@d1b d1b Fix #725 and #729.
Signed-off-by: David <db@d1b.org>
61cc16d
@d1b d1b Clean up the _get_build_prefix code - close the open fd and print the…
… error message if the fd could not be opened (denied).

Signed-off-by: David <db@d1b.org>
9c5b58f
@d1b d1b Update the code _get_build_prefix to raise an exception instead of sy…
…s.exit()'ing and also document that on windows user temp directories are already isolated.

Signed-off-by: David <db@d1b.org>
d89b580
@d1b d1b In the os.open call to get the fd to check if the user specific build…
… directory

is in fact owned by another user - add the os.O_NOFOLLOW flag to not follow symbolic links.

Signed-off-by: David <db@d1b.org>
502ae9b
@d1b d1b Provide a test to cover the changes to pip/locations.py regarding the…
… use of

the_get_build_prefix method to create a user specific build_prefix directory.

Signed-off-by: David <db@d1b.org>
d3d817c
@d1b d1b Also un-patch the patched getpass.getuser method.
Signed-off-by: David <db@d1b.org>
bfd651d
@d1b d1b Fix #725 and #729.
Signed-off-by: David <db@d1b.org>
eeaa64d
@d1b d1b Clean up the _get_build_prefix code - close the open fd and print the…
… error message if the fd could not be opened (denied).

Signed-off-by: David <db@d1b.org>
e7bf29e
@d1b d1b Update the code _get_build_prefix to raise an exception instead of sy…
…s.exit()'ing and also document that on windows user temp directories are already isolated.

Signed-off-by: David <db@d1b.org>
61c444e
@d1b d1b In the os.open call to get the fd to check if the user specific build…
… directory

is in fact owned by another user - add the os.O_NOFOLLOW flag to not follow symbolic links.

Signed-off-by: David <db@d1b.org>
dc3a359
@d1b d1b Provide a test to cover the changes to pip/locations.py regarding the…
… use of

the_get_build_prefix method to create a user specific build_prefix directory.

Signed-off-by: David <db@d1b.org>
8baeeba
@d1b d1b Also un-patch the patched getpass.getuser method.
Signed-off-by: David <db@d1b.org>
7f13624
@d1b d1b Merge branch 'fix_pip_build_directory' of github.com:d1b/pip into fix…
…_pip_build_directory

Conflicts:
	pip/locations.py

Signed-off-by: David <db@d1b.org>
5c10fc5
@qwcode qwcode use assert_raises a489c64
@qwcode qwcode test when build dir is owned by yourself f6b6ef3
@qwcode qwcode windows test fixes 841ad58
@qwcode qwcode update docs with new build dir 0366602
@qwcode qwcode update changelog and authors 427b5d4
@qwcode qwcode setup.py read function fix 3cb35d0
@qwcode qwcode merged commit 86dec5e into pypa:develop Jan 26, 2013
@qwcode
Collaborator
qwcode commented Jan 26, 2013

aw man, there are duplicated commits in here... will reset and clean up : (

@qwcode
Collaborator
qwcode commented Jan 26, 2013

hmm, the dupes were present already in from @d1b's fix_pip_buid_directory branch, just didn't see them.

@qwcode
Collaborator
qwcode commented Jan 26, 2013

2nd attempt at this is in pull #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment