Basic Authentication #786

Merged
merged 0 commits into from Mar 12, 2013

Projects

None yet

4 participants

@saxix

When you use a private, password protected, repository you can use "--index-url https://user:pass@example.com" on the command line to access it.

Anyway this is not suitable when you are using a Continuos Integration engine (Buildbot) because the credentials are clearly available in the log.

Usually, when you have a private repository, you store your credentials in the .pypirc file to allow you to upload the packages
This patch use the credentials in the .pypirc to load the HTTPPasswordMgrWithDefaultRealm used by the UrlOpener.
Also remove the FIXME about the 401 error handling.
It's very simple, only one file and few lines of code, but IMHO required to use pip with password protected repositories

@pnasrat

Thanks for the pull request - this needs tests for both the happy and sad path.

@saxix

great, I'll come back when ready

@saxix saxix closed this Feb 8, 2013
@saxix saxix reopened this Feb 8, 2013
@saxix saxix closed this Feb 9, 2013
@saxix saxix reopened this Feb 10, 2013
@qwcode qwcode merged commit 188ac20 into pypa:develop Mar 12, 2013

1 check passed

Details default The Travis build passed
@saxix

I was working on the merging with the ssl code, is there any interest on this pull request?

@ankostis

Yes there is interest, accessing password-protected repos is indeed necessary.
Any progress-update on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment