Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort pip cache commands when cache is disabled #8124

Merged
merged 2 commits into from Apr 24, 2020

Conversation

NoahGorny
Copy link
Contributor

@NoahGorny NoahGorny commented Apr 24, 2020

Resolves #8120
Seems important enough to be included in this release

@NoahGorny NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from 3ca1b9f to 410dfa1 Compare Apr 24, 2020
@NoahGorny NoahGorny changed the title Abort cache when no cache dir Abort pip cache commands when cache is disabled Apr 24, 2020
@@ -48,6 +48,11 @@ def run(self, options, args):
"purge": self.purge_cache,
}

if not options.cache_dir:
logger.error("Pip cache commands can not "
Copy link
Contributor

@gutsytechster gutsytechster Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be pip instead of Pip :)

Copy link
Member

@uranusjr uranusjr Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Otherwise LGTM.

Suggested change
logger.error("Pip cache commands can not "
logger.error("pip cache commands can not "

Copy link
Contributor

@deveshks deveshks Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should it be cannot instead of can not ?

Copy link
Contributor Author

@NoahGorny NoahGorny Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like can not more, but I am open to other ideas 😄
Also, thanks for the feedback guys! @uranusjr @gutsytechster @deveshks

@NoahGorny NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from 410dfa1 to c02fc79 Compare Apr 24, 2020
@pytest.mark.parametrize("command", ["info", "list", "remove", "purge"])
def test_cache_abort_when_no_cache_dir(script, command):
"""Running any pip cache command when cache is disabled should
abort and print informative answer"""
Copy link
Contributor

@deveshks deveshks Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: abort and log an error instead of abort and print informative answer

Copy link
Contributor Author

@NoahGorny NoahGorny Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look now @deveshks

Copy link
Contributor

@deveshks deveshks Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good 😊

@NoahGorny NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from c02fc79 to 8c28b81 Compare Apr 24, 2020
@pfmoore
Copy link
Member

@pfmoore pfmoore commented Apr 24, 2020

@pradyunsg This should be included in 20.1.0 final, but I'll leave you to make the final decision and merge as RM.

@xavfernandez xavfernandez added this to the 20.1 milestone Apr 24, 2020
@pradyunsg pradyunsg merged commit 6a7bf94 into pypa:master Apr 24, 2020
32 checks passed
@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Apr 24, 2020

@pfmoore Thanks for the mention! The corresponding issue had already been added. :)

Thanks @uranusjr @pfmoore and @xavfernandez for reviewing and @NoahGorny for the PR! ^>^

@deveshks
Copy link
Contributor

@deveshks deveshks commented Apr 28, 2020

Just saw that in the changelog docs for this bug, the issue number is 8124, (the PR number) , rather than 8120, which is the issue number.

I believe this is caused by the newsfile being named 8124.bugfix instead of 8120.bugfix

How do we generally fix such a thing (do we just manually modify https://github.com/pypa/pip/blob/master/NEWS.rst ? ). I see a few other links in changelog pointing to PRs as well.

@NoahGorny
Copy link
Contributor Author

@NoahGorny NoahGorny commented Apr 28, 2020

Oh no, I did not know it should point to the issue number and not the PR one :(
Big mistake of mine :sad:

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Apr 28, 2020

I think it’s fine either way. Of course it’s preferrable to point to the issue, but it doesn’t matter much in this case since it only takes minimal amount of time to find the corresponding issue from this PR anyway.

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Apr 29, 2020

It's certainly not a big deal or a big mistake in any way. The point of those references in the changelog, is to provide a way for folks to get to the corresponding discussion and implementation, which is clearly still possible.

If someone somehow gets mad/annoyed that they had to click 1 more time than for other news entries to get to the issue... well, they can file a PR changing NEWS.rst. :)

bors bot added a commit to duckinator/emanate that referenced this issue May 13, 2020
118: Update pip to 20.1 r=duckinator a=pyup-bot


This PR updates [pip](https://pypi.org/project/pip) from **20.0.2** to **20.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 20.1
   ```
   =================

Process
-------

- Document that pip 21.0 will drop support for Python 2.7.

Features
--------

- Add ``pip cache dir`` to show the cache directory. (`7350 &lt;https://github.com/pypa/pip/issues/7350&gt;`_)

Bug Fixes
---------

- Abort pip cache commands early when cache is disabled. (`8124 &lt;https://github.com/pypa/pip/issues/8124&gt;`_)
- Correctly set permissions on metadata files during wheel installation,
  to permit non-privileged users to read from system site-packages. (`8139 &lt;https://github.com/pypa/pip/issues/8139&gt;`_)
   ```
   
  
  
   ### 20.1b1
   ```
   ===================

Deprecations and Removals
-------------------------

- Remove emails from AUTHORS.txt to prevent usage for spamming, and only populate names in AUTHORS.txt at time of release (`5979 &lt;https://github.com/pypa/pip/issues/5979&gt;`_)
- Remove deprecated ``--skip-requirements-regex`` option. (`7297 &lt;https://github.com/pypa/pip/issues/7297&gt;`_)
- Building of local directories is now done in place, instead of a temporary
  location containing a copy of the directory tree. (`7555 &lt;https://github.com/pypa/pip/issues/7555&gt;`_)
- Remove unused ``tests/scripts/test_all_pip.py`` test script and the ``tests/scripts`` folder. (`7680 &lt;https://github.com/pypa/pip/issues/7680&gt;`_)

Features
--------

- pip now implements PEP 610, so ``pip freeze`` has better fidelity
  in presence of distributions installed from Direct URL requirements. (`609 &lt;https://github.com/pypa/pip/issues/609&gt;`_)
- Add ``pip cache`` command for inspecting/managing pip&#39;s wheel cache. (`6391 &lt;https://github.com/pypa/pip/issues/6391&gt;`_)
- Raise error if ``--user`` and ``--target`` are used together in ``pip install`` (`7249 &lt;https://github.com/pypa/pip/issues/7249&gt;`_)
- Significantly improve performance when ``--find-links`` points to a very large HTML page. (`7729 &lt;https://github.com/pypa/pip/issues/7729&gt;`_)
- Indicate when wheel building is skipped, due to lack of the ``wheel`` package. (`7768 &lt;https://github.com/pypa/pip/issues/7768&gt;`_)
- Change default behaviour to always cache responses from trusted-host source. (`7847 &lt;https://github.com/pypa/pip/issues/7847&gt;`_)
- An alpha version of a new resolver is available via ``--unstable-feature=resolver``. (`988 &lt;https://github.com/pypa/pip/issues/988&gt;`_)

Bug Fixes
---------

- Correctly freeze a VCS editable package when it is nested inside another VCS repository. (`3988 &lt;https://github.com/pypa/pip/issues/3988&gt;`_)
- Correctly handle ``%2F`` in URL parameters to avoid accidentally unescape them
  into ``/``. (`6446 &lt;https://github.com/pypa/pip/issues/6446&gt;`_)
- Reject VCS URLs with an empty revision. (`7402 &lt;https://github.com/pypa/pip/issues/7402&gt;`_)
- Warn when an invalid URL is passed with ``--index-url`` (`7430 &lt;https://github.com/pypa/pip/issues/7430&gt;`_)
- Use better mechanism for handling temporary files, when recording metadata
  about installed files (RECORD) and the installer (INSTALLER). (`7699 &lt;https://github.com/pypa/pip/issues/7699&gt;`_)
- Correctly detect global site-packages availability of virtual environments
  created by PyPA’s virtualenv&gt;=20.0. (`7718 &lt;https://github.com/pypa/pip/issues/7718&gt;`_)
- Remove current directory from ``sys.path`` when invoked as ``python -m pip &lt;command&gt;`` (`7731 &lt;https://github.com/pypa/pip/issues/7731&gt;`_)
- Stop failing uninstallation, when trying to remove non-existent files. (`7856 &lt;https://github.com/pypa/pip/issues/7856&gt;`_)
- Prevent an infinite recursion with ``pip wheel`` when ``$TMPDIR`` is within the source directory. (`7872 &lt;https://github.com/pypa/pip/issues/7872&gt;`_)
- Significantly speedup ``pip list --outdated`` by parallelizing index interaction. (`7962 &lt;https://github.com/pypa/pip/issues/7962&gt;`_)
- Improve Windows compatibility when detecting writability in folder. (`8013 &lt;https://github.com/pypa/pip/issues/8013&gt;`_)

Vendored Libraries
------------------

- Update semi-supported debundling script to reflect that appdirs is vendored.
- Add ResolveLib as a vendored dependency.
- Upgrade certifi to 2020.04.05.1
- Upgrade contextlib2 to 0.6.0.post1
- Upgrade distro to 1.5.0.
- Upgrade idna to 2.9.
- Upgrade msgpack to 1.0.0.
- Upgrade packaging to 20.3.
- Upgrade pep517 to 0.8.2.
- Upgrade pyparsing to 2.4.7.
- Remove pytoml as a vendored dependency.
- Upgrade requests to 2.23.0.
- Add toml as a vendored dependency.
- Upgrade urllib3 to 1.25.8.

Improved Documentation
----------------------

- Emphasize that VCS URLs using git, git+git and git+http are insecure due to
  lack of authentication and encryption (`1983 &lt;https://github.com/pypa/pip/issues/1983&gt;`_)
- Clarify the usage of --no-binary command. (`3191 &lt;https://github.com/pypa/pip/issues/3191&gt;`_)
- Clarify the usage of freeze command in the example of Using pip in your program (`7008 &lt;https://github.com/pypa/pip/issues/7008&gt;`_)
- Add a &quot;Copyright&quot; page. (`7767 &lt;https://github.com/pypa/pip/issues/7767&gt;`_)
- Added example of defining multiple values for options which support them (`7803 &lt;https://github.com/pypa/pip/issues/7803&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pip
  - Changelog: https://pyup.io/changelogs/pip/
  - Homepage: https://pip.pypa.io/
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
@nabeel0954
Copy link

@nabeel0954 nabeel0954 commented Apr 21, 2021

i am faceing this issue please help me anybody ERROR: pip cache commands can not function since cache is disabled.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants