Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement heuristic to get non-ASCII ZIP entries #8684

merged 3 commits into from Aug 4, 2020


Copy link

@uranusjr uranusjr commented Aug 2, 2020

Fix #8648. Not quite sure how to write a test for this yet. Is it even worthwhile given that Python 2 is going away in six months?

Copy link

chrahunt commented Aug 2, 2020

IMO this isn't worth an automated test as long as we can manually validate it. I can't see any of this code needing to be changed before we drop Python 2, and the addition here is nice and self-contained (and easy to remove later).

@uranusjr uranusjr force-pushed the zipfile-unicode-path-python2 branch from 9603130 to 3da7151 Compare Aug 3, 2020
@uranusjr uranusjr force-pushed the zipfile-unicode-path-python2 branch from 3da7151 to d4995cb Compare Aug 3, 2020
@uranusjr uranusjr force-pushed the zipfile-unicode-path-python2 branch from 3824286 to a12e2f1 Compare Aug 3, 2020
Copy link
Member Author

uranusjr commented Aug 3, 2020

According to #8648 (comment), paths inside a wheel should always use UTF-8. This is a lot simpler than I initially thought.

@uranusjr uranusjr marked this pull request as ready for review Aug 3, 2020
sbidoul approved these changes Aug 3, 2020
@sbidoul sbidoul added this to the 20.2.1 milestone Aug 3, 2020
@pradyunsg pradyunsg merged commit 70768de into pypa:master Aug 4, 2020
3 checks passed
@uranusjr uranusjr deleted the zipfile-unicode-path-python2 branch Aug 4, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Aug 4, 2020
bors bot added a commit to duckinator/emanate that referenced this pull request Aug 5, 2020
158: Update pip to 20.2.1 r=duckinator a=pyup-bot

This PR updates [pip]( from **20.2** to **20.2.1**.

   ### 20.2.1


- Ignore require-virtualenv in ``pip list`` (`8603 &lt;;`_)

Bug Fixes

- Correctly find already-installed distributions with dot (``.``) in the name
  and uninstall them when needed. (`8645 &lt;;`_)
- Trace a better error message on installation failure due to invalid ``.data``
  files in wheels. (`8654 &lt;;`_)
- Fix SVN version detection for alternative SVN distributions. (`8665 &lt;;`_)
- New resolver: Correctly include the base package when specified with extras
  in ``--no-deps`` mode. (`8677 &lt;;`_)
- Use UTF-8 to handle ZIP archive entries on Python 2 according to PEP 427, so
  non-ASCII paths can be resolved as expected. (`8684 &lt;;`_)

Improved Documentation

- Add details on old resolver deprecation and removal to migration documentation. (`8371 &lt;;`_)
- Fix feature flag name in docs. (`8660 &lt;;`_)


  - PyPI:
  - Changelog:
  - Homepage:

Co-authored-by: pyup-bot <>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

File encoding issue in _install_wheel (pip 20.2, python 2)
4 participants