Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching for range requests #8716

Merged
merged 1 commit into from Aug 5, 2020

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Aug 5, 2020

This fixes corrupted shallow wheels when caching is involved (resolves GH-8701) until we know better on why range responses are not cached correctly. It would be really nice if this can land as part of the next bugfix release (20.2.2).

@sbidoul sbidoul added this to the 20.2.2 milestone Aug 5, 2020
sbidoul
sbidoul approved these changes Aug 5, 2020
@chrahunt chrahunt merged commit f51bd8f into pypa:master Aug 5, 2020
3 checks passed
@pradyunsg
Copy link
Member

pradyunsg commented Aug 7, 2020

@McSinyx Could you file a PR adding a NEWS fragment for this PR and the corresponding issue -- basically "8701.bugfix" and "8716.bugfix" files containing the exact same text as support for this PR.

I think every bugfix that we're including in a bugfix release should be mentioned in the changelog. :)

@McSinyx
Copy link
Contributor Author

McSinyx commented Aug 7, 2020

I'm sorry for late response (I saw your comment just a few minutes after it was posted but decided to continue messing with GitHub Action instead 😅). TIL about the duplicate news entry handling, which is nice but I wonder why we need it for this case.

@McSinyx McSinyx deleted the fix-range-request-cache branch Aug 7, 2020
pradyunsg pushed a commit to pradyunsg/pip that referenced this pull request Aug 11, 2020
bors bot added a commit to duckinator/emanate that referenced this pull request Aug 11, 2020
162: Update pip to 20.2.2 r=duckinator a=pyup-bot


This PR updates [pip](https://pypi.org/project/pip) from **20.2.1** to **20.2.2**.



<details>
  <summary>Changelog</summary>
  
  
   ### 20.2.2
   ```
   ===================

Bug Fixes
---------

- Only attempt to use the keyring once and if it fails, don&#39;t try again.
  This prevents spamming users with several keyring unlock prompts when they
  cannot unlock or don&#39;t want to do so. (`8090 &lt;https://github.com/pypa/pip/issues/8090&gt;`_)
- Fix regression that distributions in system site-packages are not correctly
  found when a virtual environment is configured with ``system-site-packages``
  on. (`8695 &lt;https://github.com/pypa/pip/issues/8695&gt;`_)
- Disable caching for range requests, which causes corrupted wheels
  when pip tries to obtain metadata using the feature ``fast-deps``. (`8701 &lt;https://github.com/pypa/pip/issues/8701&gt;`_, `8716 &lt;https://github.com/pypa/pip/issues/8716&gt;`_)
- Always use UTF-8 to read ``pyvenv.cfg`` to match the built-in ``venv``. (`8717 &lt;https://github.com/pypa/pip/issues/8717&gt;`_)
- 2020 Resolver: Correctly handle marker evaluation in constraints and exclude
  them if their markers do not match the current environment. (`8724 &lt;https://github.com/pypa/pip/issues/8724&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pip
  - Changelog: https://pyup.io/changelogs/pip/
  - Homepage: https://pip.pypa.io/
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2020-resolver & fast-deps] BadZipFile when force-reinstalling packages
4 participants