fix distlib import error (DO NOT MERGE) #873

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@dgladkov
Contributor

dgladkov commented Mar 29, 2013

Reproduce import bug:

>>> from pip.vendor.distlib.locators import get_all_distribution_names
  import pkg_resources
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named vendor.distlib.locators
@dstufft

This comment has been minimized.

Show comment Hide comment
@dstufft

dstufft Mar 29, 2013

Owner

Just paging @vsajip so he knows about this in distlib itself.

Owner

dstufft commented Mar 29, 2013

Just paging @vsajip so he knows about this in distlib itself.

@qwcode

This comment has been minimized.

Show comment Hide comment
@qwcode

qwcode Mar 29, 2013

Contributor

yes, we won't fix/merge this directly of course.
leaving open to track.

Contributor

qwcode commented Mar 29, 2013

yes, we won't fix/merge this directly of course.
leaving open to track.

@dgladkov

This comment has been minimized.

Show comment Hide comment
@dgladkov

dgladkov Mar 29, 2013

Contributor

should I open this as distlib issue? In this commit: https://bitbucket.org/vinay.sajip/distlib/commits/f4cb060f0db07d6202e92e9c508b3e0a6e35c318 Vinay moved import into build method, so it won't cause import error unless Wheel.build() is called, but I still don't get why package needs to be imported by name when we already have relative import.

Contributor

dgladkov commented Mar 29, 2013

should I open this as distlib issue? In this commit: https://bitbucket.org/vinay.sajip/distlib/commits/f4cb060f0db07d6202e92e9c508b3e0a6e35c318 Vinay moved import into build method, so it won't cause import error unless Wheel.build() is called, but I still don't get why package needs to be imported by name when we already have relative import.

@qwcode

This comment has been minimized.

Show comment Hide comment
@qwcode

qwcode Mar 29, 2013

Contributor

sure, open an issue

Contributor

qwcode commented Mar 29, 2013

sure, open an issue

@dgladkov

This comment has been minimized.

Show comment Hide comment
@dgladkov

This comment has been minimized.

Show comment Hide comment
@pnasrat

This comment has been minimized.

Show comment Hide comment
@pnasrat

pnasrat Mar 30, 2013

Contributor

I guess we're pending a release with the fix and the re-vendor.

Contributor

pnasrat commented Mar 30, 2013

I guess we're pending a release with the fix and the re-vendor.

@qwcode

This comment has been minimized.

Show comment Hide comment
@qwcode

qwcode Apr 13, 2013

Contributor

closing, since the fix is merged in distlib. we'll get this fix upon our normal cycle of refreshing distlib.

Contributor

qwcode commented Apr 13, 2013

closing, since the fix is merged in distlib. we'll get this fix upon our normal cycle of refreshing distlib.

@qwcode qwcode closed this Apr 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment