Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Requires-Python dep even with --no-deps #8758



Copy link

Previous implementation would skip the Python version dependency introduced by Requires-Python: when --no-deps is passed. This fixes that.

I also did some minor refactorings to keep flake8 happy.

Copy link
Member Author

uranusjr commented Aug 14, 2020

Hmm, Travis is failing for PyPy 2.7 due to this (unexpected) warning:

DEPRECATION: pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support
in pip can be found at

Why does Azure’s CPython 2.7 not fail?

@pradyunsg pradyunsg added this to Needs triage in New Resolver Implementation Aug 23, 2020
@uranusjr uranusjr moved this from Needs triage to To do before prod release in New Resolver Implementation Aug 25, 2020
@uranusjr uranusjr force-pushed the new-resolver-requires-python-when-no-deps branch from 1f86410 to 5401cc6 Compare August 26, 2020 01:49
@pradyunsg pradyunsg merged commit 567630b into pypa:master Sep 2, 2020
2 checks passed
New Resolver Implementation automation moved this from To do before prod release to Done Sep 2, 2020
@uranusjr uranusjr deleted the new-resolver-requires-python-when-no-deps branch September 28, 2020 14:28
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 16, 2020
bors bot added a commit to duckinator/emanate that referenced this pull request Oct 18, 2020
192: Update pip to 20.2.4 r=duckinator a=pyup-bot

This PR updates [pip]( from **20.2.3** to **20.2.4**.

   ### 20.2.4

Deprecations and Removals

- Document that certain removals can be fast tracked. (`8417 &lt;;`_)
- Document that Python versions are generally supported until PyPI usage falls below 5%. (`8927 &lt;;`_)


- New resolver: Avoid accessing indexes when the installed candidate is preferred
  and considered good enough. (`8023 &lt;;`_)
- Improve error message friendliness when an environment has packages with
  corrupted metadata. (`8676 &lt;;`_)
- Cache package listings on index packages so they are guarenteed to stay stable
  during a pip command session. This also improves performance when a index page
  is accessed multiple times during the command session. (`8905 &lt;;`_)
- New resolver: Tweak resolution logic to improve user experience when
  user-supplied requirements conflict. (`8924 &lt;;`_)

Bug Fixes

- New resolver: Correctly respect ``Requires-Python`` metadata to reject
  incompatible packages in ``--no-deps`` mode. (`8758 &lt;;`_)
- New resolver: Pick up hash declarations in constraints files and use them to
  filter available distributions. (`8792 &lt;;`_)
- New resolver: If a package appears multiple times in user specification with
  different ``--hash`` options, only hashes that present in all specifications
  should be allowed. (`8839 &lt;;`_)

Improved Documentation

- Add ux documentation (`8807 &lt;;`_)


  - PyPI:
  - Changelog:
  - Homepage:

Co-authored-by: pyup-bot <>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
No open projects

Successfully merging this pull request may close these issues.

None yet

2 participants