New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a User Agent so that pip is identifiable in logs #901

Merged
merged 1 commit into from Apr 19, 2013

Conversation

Projects
None yet
3 participants
@dstufft
Member

dstufft commented Apr 19, 2013

This makes it easier for people to identify pip inside of logs. This is especially important for the PyPI admins/Python.org infrastructure team.

@hltbra

This comment has been minimized.

Show comment
Hide comment
@hltbra

hltbra Apr 19, 2013

Member

👍

Member

hltbra commented Apr 19, 2013

👍

dstufft added a commit that referenced this pull request Apr 19, 2013

Merge pull request #901 from pypa/dstufft/user-agent
Add a User Agent so that pip is identifiable in logs

@dstufft dstufft merged commit 2977a57 into develop Apr 19, 2013

1 check passed

default The Travis build passed
Details

@dstufft dstufft deleted the dstufft/user-agent branch Apr 19, 2013

#strip out HTTPHandler to prevent MITM spoof
for handler in director.handlers:
if isinstance(handler, urllib2.HTTPHandler):
director.handlers.remove(handler)
return director
# return director

This comment has been minimized.

@jezdez

jezdez Apr 19, 2013

Contributor

Hm?

@jezdez

jezdez Apr 19, 2013

Contributor

Hm?

This comment has been minimized.

@dstufft

dstufft Apr 19, 2013

Member

Left over comment that I left accidentally :(

@dstufft

dstufft Apr 19, 2013

Member

Left over comment that I left accidentally :(

This comment has been minimized.

@dstufft

dstufft Apr 19, 2013

Member

Fixed in latest develop.

@dstufft

dstufft Apr 19, 2013

Member

Fixed in latest develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment