Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip work with warnings converted to errors #9779

Merged
merged 2 commits into from Apr 6, 2021

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Apr 5, 2021

Fixes #9540. This is the workaround noted in that issue (ignoring the warning) and should be considered a temporary fix until setuptools gets fixed.

The new test should remain, though, as it ensures pip will work in the cpython ensurepip tests.

@pfmoore pfmoore requested a review from pradyunsg April 5, 2021 14:35
@pfmoore pfmoore mentioned this pull request Apr 5, 2021
@pfmoore pfmoore merged commit a64ab1a into pypa:main Apr 6, 2021
18 checks passed
@uranusjr
Copy link
Member

uranusjr commented Apr 6, 2021

I kind of wonder whether setuptools would be able to fix this before we ditch our runtime dependency on it.

@pfmoore pfmoore deleted the workaround_9540 branch April 6, 2021 07:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip 21.0.1 fails when run with warnings converted to errors
3 participants