Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the location warnings for now #9912



Copy link

We can revert and discuss how we want to present the message better once Python 3.8.10 is out.

Not sure what kind of news this should use.

Copy link

The removal/deprecation one?

Copy link

test_locations needs an update.

Beyond that, It might be better to keep this logic, but have it be hidden behind an environment variable like _PIP_DEBUG? Regardless, as long as this PR removes the warning being printed right now, I'm on board. :)

@uranusjr uranusjr force-pushed the sysconfig-remove-warning-for-python-release branch from 333a5f1 to f56ec32 Compare April 30, 2021 01:29
Copy link
Member Author

I’ve amended the PR to simply make the warning DEBUG level. This should be able to hide the message from casual users, but does not risk breaking any functionalities.

@pradyunsg pradyunsg merged commit 0c29bfe into pypa:main Apr 30, 2021
18 checks passed
Copy link

sbidoul commented Apr 30, 2021

Thanks @uranusjr !

@uranusjr uranusjr deleted the sysconfig-remove-warning-for-python-release branch May 4, 2021 07:01
inmantaci added a commit to inmanta/inmanta-core that referenced this pull request May 18, 2021
Bumps [pip]( from 21.0.1 to 21.1.1.
<p><em>Sourced from <a href="">pip's changelog</a>.</em></p>
<h1>21.1.1 (2021-04-30)</h1>
<h2>Deprecations and Removals</h2>
<li>Temporarily set the new &quot;Value for ... does not match&quot; location warnings level
to <em>DEBUG</em>, to hide them from casual users. This prepares pip 21.1 for CPython
inclusion, while pip maintainers digest the first intake of location mismatch
issues for the <code>distutils</code>-<code>sysconfig</code> transition. (<code>[#9912](pypa/pip#9912) &lt;;</code>_)</li>
<h2>Bug Fixes</h2>
<li>This change fixes a bug on Python <!-- raw HTML omitted -->`_)</li>
<li>Fix compatibility between distutils and sysconfig when the project name is unknown outside of a virtual environment. (<code>[#9838](pypa/pip#9838) &lt;;</code>_)</li>
<li>Fix Python 3.6 compatibility when a PEP 517 build requirement itself needs to be
built in an isolated environment. (<code>[#9878](pypa/pip#9878) &lt;;</code>_)</li>
<h1>21.1 (2021-04-24)</h1>
<li>Start installation scheme migration from <code>distutils</code> to <code>sysconfig</code>. A
warning is implemented to detect differences between the two implementations to
encourage user reports, so we can avoid breakages before they happen.</li>
<li>Add the ability for the new resolver to process URL constraints. (<code>[#8253](pypa/pip#8253) &lt;;</code>_)</li>
<li>Add a feature <code>--use-feature=in-tree-build</code> to build local projects in-place
when installing. This is expected to become the default behavior in pip 21.3;
see <code>Installing from local packages &lt;;</code>_
for more information. (<code>[#9091](pypa/pip#9091) &lt;;</code>_)</li>
<li>Bring back the &quot;(from versions: ...)&quot; message, that was shown on resolution failures. (<code>[#9139](pypa/pip#9139) &lt;;</code>_)</li>
<li>Add support for editable installs for project with only setup.cfg files. (<code>[#9547](pypa/pip#9547) &lt;;</code>_)</li>
<li>Improve performance when picking the best file from indexes during <code>pip install</code>. (<code>[#9748](pypa/pip#9748) &lt;;</code>_)</li>
<li>Warn instead of erroring out when doing a PEP 517 build in presence of
<code>--build-option</code>. Warn when doing a PEP 517 build in presence of
<code>--global-option</code>. (<code>[#9774](pypa/pip#9774) &lt;;</code>_)</li>
<h2>Bug Fixes</h2>
<li>Fixed <code>--target</code> to work with <code>--editable</code> installs. (<code>[#4390](pypa/pip#4390) &lt;;</code>_)</li>
<li>Add a warning, discouraging the usage of pip as root, outside a virtual environment. (<code>[#6409](pypa/pip#6409) &lt;;</code>_)</li>
<!-- raw HTML omitted -->
<p>... (truncated)</p>
<li><a href=""><code>c53d88c</code></a> Bump for release</li>
<li><a href=""><code>4417e7f</code></a> Update AUTHORS.txt</li>
<li><a href=""><code>0c29bfe</code></a> Merge pull request <a href="">#9912</a> from uranusjr/sysconfig-remove-warning-for-python-re...</li>
<li><a href=""><code>f56ec32</code></a> Make location mismatch messages DEBUG level</li>
<li><a href=""><code>999b121</code></a> Merge pull request <a href="">#9883</a> from uranusjr/isolated-pip-py36-compat</li>
<li><a href=""><code>f884203</code></a> Fallback to self-invoke via directory on 3.6</li>
<li><a href=""><code>7a77484</code></a> Merge pull request <a href="">#9835</a> from jamescurtin/9831-bugfix</li>
<li><a href=""><code>914bcc3</code></a> Merge pull request <a href="">#9838</a> from uranusjr/sysconfig-header-with-none-project</li>
<li><a href=""><code>2a009a0</code></a> Better explanatory comment</li>
<li><a href=""><code>e7b1722</code></a> Set dist_name to UNKNOWN when empty outside venv</li>
<li>Additional commits viewable in <a href="">compare view</a></li>
<br />

[![Dependabot compatibility score](](

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)


<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants