New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot do: pipenv uninstall --skip-lock despite documentation #2848

Closed
Overdrivr opened this Issue Sep 13, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@Overdrivr

Overdrivr commented Sep 13, 2018

Issue description

Using the --skip-lock flag with pipenv uninstall results in :

Error: no such option: --skip-lock

Although the documentation states that:

$ pipenv uninstall supports all of the parameters in pipenv install, [...]

(therefore including --skip-lock)

Obviously, this can be a simple documentation fix, but it would be more interesting to add the skip-lock flag to pipenv uninstall. This is interesting for CI environments, where you might want to drop a package temporarily and don't care about locking the dependencies (that takes a significant amount of times, > 7 mins in my env). In one word: speedup.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Sep 13, 2018

Hmmm that is an interesting suggestion. It seems straightforward — if it’s present in your pipfile, we can remove it, if not, it will just be removed from the lockfile.

This makes sense to me simply as an interface over your pipfile from a UX standpoint. However locking should also benefit from speedups we added a long time ago related to caching, so there may be more going on here

@jkleint

This comment has been minimized.

jkleint commented Oct 15, 2018

As of 2018.10.13, pipenv uninstall accepts --skip-lock but does not honor it:

$ pipenv uninstall csvkit --skip-lock
Un-installing csvkit…
Uninstalling csvkit-1.0.3:
  Successfully uninstalled csvkit-1.0.3

Removing csvkit from Pipfile…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Updated Pipfile.lock (4c3760)!

techalchemy added a commit that referenced this issue Nov 3, 2018

Respect --skip-lock option for uninstall
- Fixes #2848

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment