New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line option "--bare" has no effect in "sync" and "clean" actions #3041

Closed
cubranic opened this Issue Oct 15, 2018 · 6 comments

Comments

4 participants
@cubranic

cubranic commented Oct 15, 2018

Issue description

The --bare flag is supposed to set "minimal output" in sync and clean, but I don't see any difference with and without it. Looking at the code implementing those actions, I see bare in the list of parameters for do_sync and do_clean, but they are not used anywhere in the body of those functions.

Expected result

No output when --bare is used in pipenv sync.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Oct 16, 2018

Yep, that's definitely right. It's been at the back of my mind to do something about this for awhile but there is a pretty sizeable project to tackle around output cleanup in general

@frostming

This comment has been minimized.

Collaborator

frostming commented Oct 16, 2018

I think the meaning of 'bare' here is to run the command on itself, instead of called by other commands. So if you run pipenv sync, the 'bare' flag should be True by default.

Just to share what is in my head.

@cubranic

This comment has been minimized.

cubranic commented Oct 16, 2018

@frostming Check the help text for the --bare option: that demonstrably is not what it is intended to be.
Then look at any other command where it's actually functional. There are various lines where status is printed wrapped in if not bare:.

@frostming

This comment has been minimized.

Collaborator

frostming commented Oct 16, 2018

@cubranic ya you are right. I didn't check source code thoroughly.

@jcrotts jcrotts referenced this issue Oct 19, 2018

Closed

Add --bare behavior to sync and clean #3064

2 of 2 tasks complete
@jcrotts

This comment has been minimized.

Contributor

jcrotts commented Oct 19, 2018

Opened a PR for this, I think it addresses the behavior you described @cubranic .

@techalchemy

This comment has been minimized.

Member

techalchemy commented Oct 30, 2018

This was closed in #3126 by way of #3064 and will be in the next release, thanks @jcrotts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment