-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
pipenv 2020.4.1b1: Invalid fragment string #4217
Copy link
Copy link
Closed
Labels
Category: Dependency ResolutionIssue relates to dependency resolution.Issue relates to dependency resolution.Category: VCSRelates to version control system dependencies.Relates to version control system dependencies.Type: Bug 🐛This issue is a bug.This issue is a bug.Type: RegressionThis issue is a regression of a previous behavior.This issue is a regression of a previous behavior.Type: Release BlockerMust be resolved before the next release can be cut.Must be resolved before the next release can be cut.
Milestone
Metadata
Metadata
Assignees
Labels
Category: Dependency ResolutionIssue relates to dependency resolution.Issue relates to dependency resolution.Category: VCSRelates to version control system dependencies.Relates to version control system dependencies.Type: Bug 🐛This issue is a bug.This issue is a bug.Type: RegressionThis issue is a regression of a previous behavior.This issue is a regression of a previous behavior.Type: Release BlockerMust be resolved before the next release can be cut.Must be resolved before the next release can be cut.
I installed pipenv 2020.4.1b1 on my local machine by running:
Then I updated my dependencies on my local machine by running:
The Pipfile.lock got updated of course. Here is the relevant diff in Pipfile.lock:
"robohash": { "git": "https://github.com/e1ven/Robohash.git", - "ref": "03ade66998c15735740ec4111b5da8d4383a7577" + "ref": "03ade66998c15735740ec4111b5da8d4383a7577", + "version": "==1.0" },As you can see, this dependency is installed from GitHub, not from PyPI. Using the newer pipenv caused a new key-value to be added, which is
"version": "==1.0".I committed these changes and launched them to a server. The server has Pipenv 2018.5.18 installed. When the server tried to install the dependencies from this Pipfile.lock, I got this error:
It looks like the new key-value pair
versionis incompatible with pipenv 2018.5.18, when it applies to packages installed from a Git repo. Is that correct? Is it meant to be that way? If it is, it would be useful to include this compatibility notice in the change log. If not, then maybe theversionkey-value shouldn't be included in packages that are installed from a Git repo.