-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Description
Issue description
If Locale is ja_JP.UTF-8, bash completion broken.
It has been fixed in click 8.0.2. ( Bash version detection is locale independent. :issue:1940)
https://github.com/pallets/click/blob/main/CHANGES.rst#version-802
Expected result
Bash completion work on not LANG=en environments.
Actual result
Not work bash completion on not LANG=en environments.
Steps to replicate
$ echo $LANG
ja_JP.UTF-8
$ bash --version
GNU bash, バージョン 5.1.8(1)-release (x86_64-apple-darwin20.3.0)
Copyright (C) 2020 Free Software Foundation, Inc.
ライセンス GPLv3+: GNU GPL バージョン 3 またはそれ以降 <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ bash -c 'echo ${BASH_VERSION}'
5.1.8(1)-release
$ pipenv --version
pipenv, version 2021.11.9
$ eval "$(_PIPENV_COMPLETE=bash_source pipenv)"
Traceback (most recent call last):
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/bin/pipenv", line 8, in <module>
sys.exit(cli())
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1137, in __call__
return self.main(*args, **kwargs)
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1057, in main
self._main_shell_completion(extra, prog_name, complete_var)
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1132, in _main_shell_completion
rv = shell_complete(self, ctx_args, prog_name, complete_var, instruction)
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 45, in shell_complete
echo(comp.source())
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 324, in source
self._check_version()
File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 319, in _check_version
raise RuntimeError(
RuntimeError: Couldn't detect Bash version, shell completion is not supported.
$ pipenv --support
Pipenv version: '2021.11.9'
Pipenv location: '/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv'
Python location: '/usr/local/Cellar/pipenv/2021.11.9/libexec/bin/python3.10'
Python installations found:
3.9.7:/usr/local/opt/python@3.9/libexec/bin/python3.9.7:/usr/local/bin/python33.9.7:/usr/local/bin/python3.93.9.6:/Users/***/.pyenv/versions/3.9.6/bin/python33.9.5:/Users/***/.pyenv/versions/3.9.5/bin/python33.9.4:/Users/***/.pyenv/versions/3.9.4/bin/python33.9.2:/Users/***/.pyenv/versions/3.9.2/bin/python33.8.10:/Users/***/.pyenv/versions/3.8.10/bin/python33.8.9:/Users/***/.pyenv/versions/3.8.9/bin/python33.8.8:/Users/***/.pyenv/versions/3.8.8/bin/python33.8.2:/usr/bin/python33.7.10:/Users/***/.pyenv/versions/3.7.10/bin/python32.7.16:/usr/bin/python2.7.16:/usr/bin/python22.7.16:/usr/bin/python2.7
PEP 508 Information:
{'implementation_name': 'cpython',
'implementation_version': '3.10.0',
'os_name': 'posix',
'platform_machine': 'x86_64',
'platform_python_implementation': 'CPython',
'platform_release': '20.6.0',
'platform_system': 'Darwin',
'platform_version': 'Darwin Kernel Version 20.6.0: Tue Oct 12 18:33:42 PDT '
'2021; root:xnu-7195.141.8~1/RELEASE_X86_64',
'python_full_version': '3.10.0',
'python_version': '3.10',
'sys_platform': 'darwin'}
System environment variables:
PATHTERM_PROGRAMGPT_TTYPYENV_ROOTTERMPIPENV_VERBOSITYSHELLHISTSIZETMPDIRPIPENV_VENV_IN_PROJECTTERM_PROGRAM_VERSIONTERM_SESSION_IDUSERCOMMAND_MODEGUILE_LOAD_PATHCCACHE_DIRSSH_AUTH_SOCK__CF_USER_TEXT_ENCODINGGUILE_LOAD_COMPILED_PATHBASH_COMPLETION_COMPAT_DIRGUILE_TLS_CERTIFICATE_DIRECTORY___CFBundleIdentifierPWDHOMEBREW_GITHUB_API_TOKENLANGITERM_PROFILEXPC_FLAGSITERM_ORIG_PS1XPC_SERVICE_NAMEHISTCONTROLSHLVLCOLORFGBGHOMEPYENV_SHELLLC_TERMINAL_VERSIONITERM_PREV_PS1ITERM_SESSION_IDLOGNAMEGUILE_SYSTEM_EXTENSIONS_PATHUSE_CCACHEPROMPT_COMMANDLC_TERMINALCOLORTERMPIP_SHIMS_BASE_MODULEPIP_DISABLE_PIP_VERSION_CHECKPYTHONDONTWRITEBYTECODEPIP_PYTHON_PATHPYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
PIPENV_VERBOSITY:-1PIPENV_VENV_IN_PROJECT:1
Debug–specific environment variables:
PATH:/usr/local/Cellar/pipenv/2021.11.9/libexec/tools:/Users/***/.pyenv/shims:/Users/***/.pyenv/bin:/usr/local/opt/libpq/bin:/usr/local/opt/python@3.9/libexec/bin:/usr/local/opt/mysql-client/bin:/usr/local/opt/curl/bin:/usr/local/opt/php@7.4/bin:/usr/local/opt/ccache/libexec:/usr/local/sbin:/usr/local/bin:~/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/PublicSHELL:/usr/local/bin/bashLANG:ja_JP.UTF-8PWD:/Users/***
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels