-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP517 packages can silently fail to install #5031
Comments
@jonathan-conder-sm I was not able to reproduce with the base example.
Which package is a PEP517 package that fails to install? |
pycocotools will fail to install if you don't have gcc installed (which is why I removed it in the repro steps). Obviously the fix is to just install |
Thanks for the added details @jonathan-conder-sm -- I can see it in the output too when passing -v that it fails to build, and you are right, it appears as though it was successful.
|
for some added context I think the problem is around here: Line 672 in 45f3237
maybe the "not retry" branch should come before the pep517 stuff? |
Or maybe this should be a while loop: Line 887 in 45f3237
|
@jonathan-conder-sm I believe my branch fixes this issue: #5046
|
thanks, LGTM |
Issue description
When
pipenv sync
fails to install a PEP517 package, the exit code is0
.I think this might be because
uses_pep517
is never used (elsewhere it is referred to asuse_pep517
).Expected result
pipenv sync
should exit with a nonzero error code.Actual result
Steps to replicate
$ pipenv --support
Pipenv version:
'2022.3.28'
Pipenv location:
'/usr/local/lib/python3.9/site-packages/pipenv'
Python location:
'/usr/local/bin/python'
Python installations found:
3.9.12
:/usr/local/bin/python
3.9.12
:/usr/local/bin/python3.9
3.9.12
:/usr/local/bin/python3
3.9.2
:/usr/bin/python3.9
3.9.2
:/usr/bin/python3
PEP 508 Information:
System environment variables:
HOSTNAME
PYTHON_VERSION
PWD
PYTHON_SETUPTOOLS_VERSION
HOME
LANG
GPG_KEY
TERM
SHLVL
PYTHON_PIP_VERSION
PYTHON_GET_PIP_SHA256
PYTHON_GET_PIP_URL
PATH
_
PIP_SHIMS_BASE_MODULE
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
Debug–specific environment variables:
PATH
:/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG
:C.UTF-8
PWD
:/
Contents of
Pipfile
('/Pipfile'):Contents of
Pipfile.lock
('/Pipfile.lock'):The text was updated successfully, but these errors were encountered: