Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we are not in a virtualenv if aborting #2181

Merged

Conversation

@pegler
Copy link
Contributor

@pegler pegler commented May 11, 2018

Fixes #2078

@uranusjr
Copy link
Member

@uranusjr uranusjr commented May 12, 2018

Thanks for the fix! The logic looks correct to me, but we probably want to add a comment there so make sure people reading the code in the future know exactly when (and why) we should abort. Would you be able to add this?

@pegler
Copy link
Contributor Author

@pegler pegler commented May 12, 2018

Done!

techalchemy added 2 commits May 15, 2018
@techalchemy
Copy link
Member

@techalchemy techalchemy commented May 15, 2018

Thanks for the PR! Will merge after CI

@techalchemy techalchemy merged commit d1957f1 into pypa:master May 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pegler pegler deleted the pegler:bugfix/2078a-allow-locking-in-virtualenv branch May 17, 2018
@pegler
Copy link
Contributor Author

@pegler pegler commented May 24, 2018

hey @techalchemy, is there a release planned for sometime soon that will get this live?

@techalchemy
Copy link
Member

@techalchemy techalchemy commented May 24, 2018

@pegler in the next couple of days, we have some performance enhancements in the pipeline that I really want to get into the release if possible

@techalchemy
Copy link
Member

@techalchemy techalchemy commented May 24, 2018

If i have the time I will release sooner, depends how smoothly these all go

@pegler
Copy link
Contributor Author

@pegler pegler commented May 24, 2018

sounds good. thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.