New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nelfin fix 2229 #2262

Merged
merged 2 commits into from Jun 1, 2018

Conversation

Projects
2 participants
@uranusjr
Member

uranusjr commented May 25, 2018

Manual merge. Close #2230.

@uranusjr

This comment has been minimized.

Member

uranusjr commented May 25, 2018

Urrgh Buildkite is failing and I can’t even see its logs.

nelfin added some commits May 21, 2018

Add test of behaviour in issue #2229
requirements.txt files (and by extension pipfreeze) can contain comment
lines, but the stdout of pip freeze is used in a number of places with
the assumption that every line contains a dependency declaration. This
change adds an integration test that could trigger one of these cases
that was the cause of the behaviour seen in issue #2229.
Fix IndexError parsing comments from `pip freeze`
Ref #2229. This change only fixes the issue seen when calling `pipenv
clean`. A future refactor should consolidate these behaviours (or use
the actual parsing of lines from pip, i.e. FrozenRequirement, if we can
rely on this API).

@uranusjr uranusjr force-pushed the nelfin-fix-2229 branch from b9e43e2 to 5788db3 May 31, 2018

@uranusjr uranusjr merged commit f91f53b into master Jun 1, 2018

2 checks passed

buildkite/pipenv Build #222 passed (6 minutes, 23 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@techalchemy techalchemy deleted the nelfin-fix-2229 branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment