Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nelfin fix 2229 #2262

merged 2 commits into from
Jun 1, 2018

Nelfin fix 2229 #2262

merged 2 commits into from
Jun 1, 2018


Copy link

Manual merge. Close #2230.

Copy link
Member Author

Urrgh Buildkite is failing and I can’t even see its logs.

requirements.txt files (and by extension pipfreeze) can contain comment
lines, but the stdout of pip freeze is used in a number of places with
the assumption that every line contains a dependency declaration. This
change adds an integration test that could trigger one of these cases
that was the cause of the behaviour seen in issue #2229.
Ref #2229. This change only fixes the issue seen when calling `pipenv
clean`. A future refactor should consolidate these behaviours (or use
the actual parsing of lines from pip, i.e. FrozenRequirement, if we can
rely on this API).
@uranusjr uranusjr merged commit f91f53b into master Jun 1, 2018
@techalchemy techalchemy deleted the nelfin-fix-2229 branch June 8, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects

Successfully merging this pull request may close these issues.

None yet

2 participants