Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner shell history #2287

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Cleaner shell history #2287

merged 2 commits into from
Jun 11, 2018

Conversation

skurfer
Copy link
Contributor

@skurfer skurfer commented Jun 1, 2018

ZSH has a HIST_IGNORE_SPACE option that prevents any command prefixed with a space from appearing in the history. I’ve added a space to the activation command to take advantage of this.

For most users, it will make no difference, but for ZSH users with that option set, it’ll prevent useless noise in their history.

@uranusjr
Copy link
Member

uranusjr commented Jun 1, 2018

Makes sense to me. Bash has something similar too.

For ZSH users with HIST_IGNORE_SPACE, this will keep activation noise out of the shell’s history.
@uranusjr uranusjr added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Jun 7, 2018
@uranusjr
Copy link
Member

uranusjr commented Jun 7, 2018

Need admin privilege to merge this one :(

@techalchemy techalchemy added this to In progress in 2018.06.x Release Jun 10, 2018
@techalchemy
Copy link
Member

I'm good with this once we merge the other prs, I'll just update this one and we can verify it passes before merging

@techalchemy techalchemy self-assigned this Jun 11, 2018
@techalchemy techalchemy merged commit 863ebbd into pypa:master Jun 11, 2018
2018.06.x Release automation moved this from In progress to Done Jun 11, 2018
@skurfer skurfer deleted the shell-history branch June 12, 2018 13:50
@techalchemy techalchemy moved this from Done to Needs Changelog in 2018.06.x Release Jun 16, 2018
@techalchemy techalchemy moved this from Needs Changelog to Done in 2018.06.x Release Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants