New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PATHEXT when looking for Win executable #2298

Merged
merged 1 commit into from Jun 3, 2018

Conversation

Projects
2 participants
@uranusjr
Member

uranusjr commented Jun 3, 2018

On Windows, the environment variable PATHEXT holds a list (;-separated) of extensions that Windows use to look up an executable file when the user enters a (extension-less) command into the prompt. This rewrite makes find_windows_executable mimic this behaviour.

Fix #2282.

Respect PATHEXT when looking for Win executable
... as idiomatic in Windows programming.

@uranusjr uranusjr force-pushed the windows-find-executable-pathext branch from cdb6b17 to d48e97e Jun 3, 2018

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jun 3, 2018

Buildkite failure was the non-deterministic build failure for the yarl lock, merging (and thanks)

@techalchemy techalchemy merged commit 19b05b4 into master Jun 3, 2018

1 of 2 checks passed

buildkite/pipenv Build #226 failed (8 minutes, 24 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@techalchemy techalchemy deleted the windows-find-executable-pathext branch Jun 3, 2018

@techalchemy techalchemy moved this from Done to Needs Changelog in 2018.06.x Release Jun 16, 2018

@techalchemy techalchemy moved this from Needs Changelog to Done in 2018.06.x Release Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment