Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint “pipenv run” after creating the virtualenv #2312

Merged
merged 2 commits into from Jun 14, 2018
Merged

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 6, 2018

We should try to promote pipenv run more. pipenv shell is almost never a good idea outside the development phase, but as things currently stand people are using it when they shouldn’t.

Also some refactoring to remove dead code and misleading function name.

@uranusjr uranusjr changed the title Hint "pipenv run" after creating the virtualenv Hint “pipenv run” after creating the virtualenv Jun 6, 2018
@uranusjr uranusjr force-pushed the pipenv-run-in-hint branch from 013a621 to c2dea69 Jun 6, 2018
@techalchemy techalchemy added this to In progress in 2018.06.x Release Jun 10, 2018
Also some refactoring to remove dead code and misleading function name.
@uranusjr uranusjr force-pushed the pipenv-run-in-hint branch from 72a3377 to fcc4dc5 Jun 12, 2018
@uranusjr uranusjr merged commit 4b95004 into master Jun 14, 2018
2 checks passed
2 checks passed
buildkite/pipenv Build #388 passed (21 minutes, 38 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
2018.06.x Release automation moved this from In progress to Done Jun 14, 2018
@techalchemy techalchemy deleted the pipenv-run-in-hint branch Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.