New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion methods for requires-python formats #2377

Merged
merged 3 commits into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@techalchemy
Member

techalchemy commented Jun 18, 2018

  • Handle single-digit un-specified requires-python format
  • Requires-Python: 3 should be functionally equivalent to >=3,<4
  • Fixes #2343
if c.requires_python:
# Old specifications had people setting this to single digits
# which is effectively the same as '>=digit,<digit+1'
if len(c.requires_python) == 1 and c.requires_python.isdigit():

This comment has been minimized.

@uranusjr

uranusjr Jun 18, 2018

Member

The len(c.requires_python) ==1 part looks redundant to me, just isdigit() is enough. It does not matter practically, but if Python ever gets to 10.0 we probably want to support that as well.

techalchemy added some commits Jun 18, 2018

Add conversion methods for requires-python formats
- Handle single-digit un-specified requires-python format
- `Requires-Python: 3` should be functionally equivalent to `>=3,<4`
- Fixes #2343

Signed-off-by: Dan Ryan <dan@danryan.co>
Fix `isdigit` check and bump version to dev0
Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy force-pushed the 2343-requires-python branch from 58c3f98 to 71ff857 Jun 18, 2018

@techalchemy techalchemy merged commit 9195d3a into master Jun 18, 2018

2 checks passed

buildkite/pipenv Build #465 passed (11 minutes, 49 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@techalchemy techalchemy deleted the 2343-requires-python branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment