New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all update workflows to `pipenv lock/sync` #2379

Merged
merged 3 commits into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@techalchemy
Member

techalchemy commented Jun 18, 2018

  • pipenv update currently doesn't actually run pipenv lock
  • Semantics around this changed but it doesn't look like the code did
  • pipenv update should operate similarly for all operations by running
    lock followed by sync
  • Fixes #2179
)
do_sync(
ctx=ctx,
install=install,

This comment has been minimized.

@uranusjr

uranusjr Jun 18, 2018

Member

It is a good time to clean up arguments of sync now? (#2211 but maybe less drastic, just remove those that are really unused). My eyes roll every time I see it.

This comment has been minimized.

@techalchemy

techalchemy Jun 18, 2018

Member

i only cleaned up a few -- some i think we want to implement

techalchemy added some commits Jun 18, 2018

Switch all update workflows to `pipenv lock/sync`
- `pipenv update` currently doesn't actually run `pipenv lock`
- Semantics around this changed but it doesn't look like the code did
- `pipenv update` should operate similarly for all operations by running
`lock` followed by `sync`
- Fixes #2179

Signed-off-by: Dan Ryan <dan@danryan.co>
Add test to verify `pipenv update`
Signed-off-by: Dan Ryan <dan@danryan.co>
Remove some unused arguments during passthrough
Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy force-pushed the 2179-pipenv-update branch from 04c1fce to 0ce5b3c Jun 18, 2018

@techalchemy techalchemy merged commit d213e7c into master Jun 18, 2018

2 checks passed

buildkite/pipenv Build #462 passed (6 minutes, 55 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@techalchemy techalchemy deleted the 2179-pipenv-update branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment