Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all update workflows to pipenv lock/sync #2379

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Conversation

techalchemy
Copy link
Member

  • pipenv update currently doesn't actually run pipenv lock
  • Semantics around this changed but it doesn't look like the code did
  • pipenv update should operate similarly for all operations by running
    lock followed by sync
  • Fixes Upgrading package reinstalls old version #2179

pipenv/cli.py Outdated
)
do_sync(
ctx=ctx,
install=install,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good time to clean up arguments of sync now? (#2211 but maybe less drastic, just remove those that are really unused). My eyes roll every time I see it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only cleaned up a few -- some i think we want to implement

- `pipenv update` currently doesn't actually run `pipenv lock`
- Semantics around this changed but it doesn't look like the code did
- `pipenv update` should operate similarly for all operations by running
`lock` followed by `sync`
- Fixes #2179

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@uranusjr uranusjr added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Jun 18, 2018
@techalchemy techalchemy merged commit d213e7c into master Jun 18, 2018
@techalchemy techalchemy deleted the 2179-pipenv-update branch June 18, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants