New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Jinja2 templates for click_completion #2422

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@wjv
Contributor

wjv commented Jun 26, 2018

The new version of click_completion requires its Jinja2 templates to be installed along with the package in order to work. If not, any invocation of pipenv --completion results in a jinja2.exceptions.TemplateNotFound for the template in question.

I’ve just trivially added the pattern to setup.py, and tested that it works.

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jun 26, 2018

@techalchemy We’ll need another release very soon 🤦‍♂️

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jun 26, 2018

Today is the plan

@techalchemy techalchemy merged commit 2db0e62 into pypa:master Jun 26, 2018

2 checks passed

buildkite/pipenv Build #540 passed (6 minutes, 36 seconds)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@acdha acdha referenced this pull request Jun 26, 2018

Closed

pipenv 2018.6.25 #29435

@ilovezfs

This comment has been minimized.

ilovezfs commented Jun 26, 2018

Is this sufficient to make sure they end up in the sdist too?

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jun 26, 2018

@ilovezfs It should, I think.

@daogilvie

This comment has been minimized.

Contributor

daogilvie commented Jun 29, 2018

@ilovezfs @uranusjr Hi — sadly it looks like the latest commit of master, with this PR merged, does not include the files in the sdist under setuptools 39.0.1, as I am just discovering now 😂 . I don't really grok Python packaging sometimes, but I have found adding include pipenv/vendor/click_completion/*.j2 to the MANIFEST.in solves the problem. I can reopen an issue and/or make a PR, but I don't want to just assume you are happy with the solution of adding to the MANIFEST.in file.

For completeness I have tried CPython 3.6.5 and 2.7.15 on MacOS high sierra. The sdist as generated there is affected, as is the one installed by homebrew on my system.

Please advise if I'm somehow using a bad branch, but the merge commit for this PR is in the git log so I'm pretty sure it's in there.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jun 29, 2018

We didn’t actually release an sdist yet but I would believe that our manifest doesn’t include these. Feel free to PR a fix and thanks for the heads up!

@techalchemy techalchemy added this to the 2018.7.0 milestone Jul 1, 2018

@wjv wjv deleted the wjv:fix_completion branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment