New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit vendored click_completion *.j2 entry in MANIFEST.in #2479

Merged
merged 3 commits into from Jul 1, 2018

Conversation

Projects
None yet
2 participants
@daogilvie
Contributor

daogilvie commented Jun 29, 2018

This seems to be needed to make sure they are included in distributions.
Tiny change. Let me know if you want it done differently!

See #2422 for prior context.

Detecting the Problem

  1. Build a bdist or sdist with setuptools and no cached egg-info.
  2. Verify that no .j2 files are included in any of the stdout lines
  3. Optionally unpack the dists and verify the click_completion vendor directory contains no .j2 files

Detecting the fix

After doing this, verify the following:

  • The .j2 files appear as being copied in the output lines of the build log
  • The .j2 files are in the vendored directory for click_completion

Due diligence

  • Python 2.7 test suite passes
  • Python 3 test suite passes
test_resolver_unique_markers failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	assert 1 == 0
 +  where 1 = <Command 'pipenv install vcrpy==1.11.0'>.return_code
	[<TracebackEntry pipenv/tests/integration/test_install_markers.py:142>]
test_resolver_unique_markers failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	assert 1 == 0
 +  where 1 = <Command 'pipenv install vcrpy==1.11.0'>.return_code
	[<TracebackEntry pipenv/tests/integration/test_install_markers.py:142>]

I do not have time currently to investigate the reason the vcrpy spec string test fails, and cannot see an open issue for it. This was inherited before making the fix. Tests run on CPython 3.6.5, MacOS High sierra.

daogilvie and others added some commits Jun 29, 2018

Explicit vendored click_completion *.j2 entry in MANIFEST.in
This seems to be needed to make sure they are included in distributions.
@techalchemy

This comment has been minimized.

Member

techalchemy commented Jun 29, 2018

I am quite confident the test suites will pass :) thanks!

@techalchemy techalchemy added this to the 2018.7.0 milestone Jun 29, 2018

@techalchemy techalchemy self-assigned this Jun 29, 2018

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jun 29, 2018

the VCRPY issue is an old one, you may just need to clear your cache to fix it locally

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jul 1, 2018

thanks again, merging!

@techalchemy techalchemy merged commit cd47835 into pypa:master Jul 1, 2018

0 of 2 checks passed

buildkite/pipenv Build #673 started
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment