Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inline virtualenv activation logic #2503

Merged
merged 2 commits into from Jul 4, 2018

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 3, 2018

Set VIRTUAL_ENV during activation so py.exe does the right thing.

Before:

> pipenv run py -c "import sys; print(sys.executable)"
C:\Users\uranusjr\AppData\Local\Programs\Python\Python36\python.exe

After:

> pipenv run py -c "import sys; print(sys.executable)"
C:\Users\uranusjr\Documents\programming\pipenv\.venv\Scripts\python.exe

Also add venv support—it is actually quite easy, so why not.

@uranusjr
Copy link
Member Author

@uranusjr uranusjr commented Jul 3, 2018

I’m not sure why VIRTUAL_ENV was not set before. Maybe there is a reason I am not aware of?

Loading

@uranusjr uranusjr force-pushed the rewrite-inline-venv-activation branch from 633b7dd to 87124d9 Jul 3, 2018
Set VIRTUAL_ENV during activation so py.exe does the right thing. Also add
venv support --- it is actually quite easy, so why not.
@uranusjr uranusjr force-pushed the rewrite-inline-venv-activation branch from 87124d9 to eb953fe Jul 3, 2018
@kennethreitz kennethreitz merged commit fee09c9 into master Jul 4, 2018
0 of 2 checks passed
Loading
@kennethreitz kennethreitz deleted the rewrite-inline-venv-activation branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants