Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subprocess usage for Python 2 #2515

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Fix subprocess usage for Python 2 #2515

merged 1 commit into from
Jul 4, 2018

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 4, 2018

Fix #2514.

Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@@ -59,8 +59,7 @@ def _handover(cmd, args):
if os.name != "nt":
os.execvp(cmd, args)
else:
proc = subprocess.run(args, shell=True, universal_newlines=True)
sys.exit(proc.returncode)
sys.exit(subprocess.call(args, shell=True, universal_newlines=True))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t it better to PopenSpawn this? We vendor it with delegator

@techalchemy
Copy link
Member

ok on discussion i think this is good

@techalchemy techalchemy merged commit 389bd63 into master Jul 4, 2018
@uranusjr uranusjr deleted the bugfix/shell-py27 branch July 7, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants