Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use virtualenv directly, not "pew new" #2518

Merged
merged 8 commits into from Jul 5, 2018
Merged

Always use virtualenv directly, not "pew new" #2518

merged 8 commits into from Jul 5, 2018

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 4, 2018

This removed Pew references in virtualenv creation.

@uranusjr uranusjr added this to In progress in Purge Pew via automation Jul 4, 2018
This removed Pew references in virtualenv creation.
pipenv/core.py Outdated
project.virtualenv_location
or os.environ.get("VIRTUAL_ENV", "")
)
assert location and os.path.exists(location), "virtualenv not created"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably stop using asserts in our codebase as tests, since a lot of production machines disable the debug flag

@uranusjr uranusjr merged commit f5a1fa7 into master Jul 5, 2018
Purge Pew automation moved this from In progress to Done Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Purge Pew
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants