Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use virtualenv directly, not "pew new" #2518

Merged
merged 8 commits into from Jul 5, 2018
Merged

Always use virtualenv directly, not "pew new" #2518

merged 8 commits into from Jul 5, 2018

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 4, 2018

This removed Pew references in virtualenv creation.

@uranusjr uranusjr added this to In progress in Purge Pew via automation Jul 4, 2018
@uranusjr uranusjr force-pushed the purge-pew branch from 1027f87 to 18bb3ab Jul 4, 2018
This removed Pew references in virtualenv creation.
@uranusjr uranusjr force-pushed the purge-pew branch from 18bb3ab to 1d3f466 Jul 4, 2018
@uranusjr uranusjr force-pushed the purge-pew branch from 2dd6a1a to 3412972 Jul 4, 2018
project.virtualenv_location
or os.environ.get("VIRTUAL_ENV", "")
)
assert location and os.path.exists(location), "virtualenv not created"

This comment has been minimized.

@techalchemy

techalchemy Jul 4, 2018
Member

We should probably stop using asserts in our codebase as tests, since a lot of production machines disable the debug flag

@uranusjr uranusjr merged commit f5a1fa7 into master Jul 5, 2018
2 checks passed
2 checks passed
@erinxocon
VSTS: pipenv-Python Package-CI 20180705.3 succeeded
Details
buildkite/pipenv Build #775 passed (8 minutes, 9 seconds)
Details
Purge Pew automation moved this from In progress to Done Jul 5, 2018
@craynic

This comment has been minimized.

Copy link
Contributor

@craynic craynic commented on 9997611 Oct 9, 2018

seems not right.
should be: not (location and os.path.exists(location))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Purge Pew
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants