New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-vendor Pew #2521

Merged
merged 3 commits into from Jul 5, 2018

Conversation

Projects
2 participants
@uranusjr
Member

uranusjr commented Jul 5, 2018

I believe we have removed all Pew usages in the code base.

  • pewtwo entry point is deleted.
  • Removed a related test. It was already skipped.
  • Module pipenv.pew is removed.
  • Vendored pipenv.vendor.pew is removed.
  • Removed Pew from vendoring scripts.
  • Removed patches for Pew.
  • Comments and documentation is checked to rewrite Pew mentions to relevant virtualenv wording.

@uranusjr uranusjr added this to In progress in 2018.7.x Release via automation Jul 5, 2018

@uranusjr uranusjr added this to In progress in Purge Pew via automation Jul 5, 2018

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jul 5, 2018

Does this cover project creation?

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jul 5, 2018

If this passes and covers project creation I’m good with it.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jul 5, 2018

I.e pew new --project

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jul 5, 2018

Yes it does!

# Associate project directory with the environment.
# This mimics Pew's "setproject".
project_file_name = os.path.join(project.virtualenv_location, '.project')
with open(project_file_name, 'w') as f:
    f.write(fs_str(project.project_directory))

pew new --project == pew new + pew setproject.

@uranusjr uranusjr force-pushed the purge-pew branch from 0b7a388 to 06fda49 Jul 5, 2018

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jul 5, 2018

p.s. We have test for project creation.

@uranusjr uranusjr merged commit ef6e667 into master Jul 5, 2018

2 checks passed

VSTS: pipenv-Python Package-CI 20180705.7 succeeded
Details
buildkite/pipenv Build #780 passed (8 minutes, 3 seconds)
Details

Purge Pew automation moved this from In progress to Done Jul 5, 2018

2018.7.x Release automation moved this from In progress to Done Jul 5, 2018

@uranusjr uranusjr deleted the purge-pew branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment