New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `exists-action` argument passing #2610

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
2 participants
@techalchemy
Member

techalchemy commented Jul 18, 2018

Signed-off-by: Dan Ryan dan@danryan.co

Fix `exists-action` argument passing
- Fixes #2326

Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy added this to In progress in 2018.7.x Release via automation Jul 18, 2018

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jul 19, 2018

I think we should use keys in this format string now, those indexes are impossible to reason with.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Jul 19, 2018

What you dont like 3 7 4 8 5 2 6 1 as an order?

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jul 19, 2018

Ordering starts from zero obvly?

@uranusjr

This comment has been minimized.

Member

uranusjr commented Jul 19, 2018

Ah whatever, this whole thing is a mess and needs a complete rewrite.

@uranusjr uranusjr merged commit 568a9d2 into master Jul 19, 2018

2 checks passed

VSTS: pipenv-Python Package-CI 20180718.8 succeeded
Details
buildkite/pipenv Build #982 passed (7 minutes, 9 seconds)
Details

2018.7.x Release automation moved this from In progress to Done Jul 19, 2018

@uranusjr uranusjr deleted the bugfix/2326-exists-action-bug branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment