New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution using `dependency_links` with ssh #2643

Merged
merged 9 commits into from Jul 30, 2018

Conversation

Projects
2 participants
@techalchemy
Member

techalchemy commented Jul 24, 2018

Fix resolution using dependency_links with ssh

  • Exclude VCS SSH uris from hashing
  • Add additional resilience to the piptools resolver
  • Fixes #2613

techalchemy added some commits Jul 23, 2018

Enable parsing of dependency links in setup.py
- Fixed errors with url parsing during hashing

Signed-off-by: Dan Ryan <dan@danryan.co>
Fix resolution using `dependency_links` with ssh
- Exclude VCS SSH uris from hashing
- Add additional resilience to the piptools resolver
- Fixes #2613

Signed-off-by: Dan Ryan <dan@danryan.co>
Make sure there is a link to check against
Signed-off-by: Dan Ryan <dan@danryan.co>
Add chdir context manager and properly run setup.py files during reso…
…lution

Signed-off-by: Dan Ryan <dan@danryan.co>
Ensure that we use posix style strings instead of Path objects for ch…
…dir context manager

Signed-off-by: Dan Ryan <dan@danryan.co>
Handle NoneType paths
Signed-off-by: Dan Ryan <dan@danryan.co>
Add exception handling for non-existent setup_py_dir
Signed-off-by: Dan Ryan <dan@danryan.co>
Fix exception handling
Signed-off-by: Dan Ryan <dan@danryan.co>

@uranusjr uranusjr added this to In progress in 2018.7.x Release via automation Jul 30, 2018

@uranusjr uranusjr merged commit 5a55c88 into master Jul 30, 2018

2 checks passed

VSTS: pipenv-Python Package-CI 20180730.5 succeeded
Details
buildkite/pipenv Build #1052 passed (11 minutes, 6 seconds)
Details

2018.7.x Release automation moved this from In progress to Done Jul 30, 2018

@uranusjr uranusjr deleted the fix-find-links branch Jul 30, 2018

@atzannes atzannes referenced this pull request Aug 2, 2018

Merged

Add test for setup.py::dependency-link field #2688

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment