Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass verbosity to resolver #2732

Merged
merged 2 commits into from Aug 12, 2018
Merged

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 11, 2018

The issue

pipenv lock --verbose does not set PIPENV_VERBOSITY correct for the resolver subprocess, and does not correctly show verbose output.

The fix

This patch adds the verbosity value into environment variables to make sure the resolver knows itself is in verbose (or debug) mode.

Some other changes are added to make the verbose flag understood by pipenv-resolver, and works well with environment variables (using max() calls).

The checklist
  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.
Copy link
Member

@techalchemy techalchemy left a comment

Makes sense to me

@techalchemy techalchemy merged commit 541b87a into master Aug 12, 2018
1 check passed
1 check passed
buildkite/pipenv Build #1153 passed (8 minutes, 16 seconds)
Details
@techalchemy techalchemy deleted the bugfix/pass-verbosity-to-resolver branch Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants