Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create virtualenvs directory if it does not exist #2877

Merged
merged 3 commits into from Sep 29, 2018

Conversation

@Enzime
Copy link
Contributor

@Enzime Enzime commented Sep 21, 2018

The issue

This PR fixes #2786 as pipenv tries to iterate through WORKON_HOME (virtualenvs folder) without ensuring it exists first.

The fix

Creating the WORKON_HOME directory from inside pipenv/utils.py:get_workon_home.

The checklist
  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.
Enzime added a commit to Enzime/pipenv that referenced this pull request Sep 21, 2018
Copy link
Member

@uranusjr uranusjr left a comment

Thanks for the patch! The approach looks good to me, but the implementation needs some tweaks for version compatibility.

pipenv/utils.py Outdated Show resolved Hide resolved
@Enzime Enzime force-pushed the Enzime:fix/no-virtualenv-dir branch from a06056a to 55be407 Sep 21, 2018
@Enzime
Copy link
Contributor Author

@Enzime Enzime commented Sep 29, 2018

@uranusjr have you had a chance to check my PR again?

@uranusjr uranusjr merged commit 19c1f4a into pypa:master Sep 29, 2018
1 of 2 checks passed
1 of 2 checks passed
pipenv CI (Windows) #20180928.1 failed
Details
pipenv CI (Linux) #20180928.1 succeeded
Details
@Enzime Enzime deleted the Enzime:fix/no-virtualenv-dir branch Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.