Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix normalization during install #3007
referenced this pull request
Oct 11, 2018
Oct 12, 2018
Holy moly! So much headache about quoting and unquoting, and all because
This is the culprit IMHO, after all it's the library that should handle command execution. Instead arbitrary argument quoting snippets are found here and there all over pipenv.
What if a path has a space in it? What if that happens on windows? What if both of those are true and the user is using nave path separators (that is,
The short answer is that normally command line quoting should be handled by standard libraries.
It depends on what do you want to do with it. If you want to pass it forward, then again
will just work™.
If you want to handle it within pipenv, w.r.t. native/non-native path separators, it's a bit of a mess, but something along the lines of of
Same as above.
But like you say, apparently the problems pipenv is experiencing with quoting are related to