Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
use os.execl to "run" subcommand on Unix ( close #315 ) #320
Thanks for putting this together @nonylene! This seems like a reasonable first step but I do have a couple outstanding questions.
Before we remove
--no-interactive I think we should definitely make sure that this code works on Docker, particularly Alpine Linux which this was added for. Also running this inside of nested shell calls should be verified.
I'd also like @kennethreitz to give this a go ahead before we remove
--no-interactive. That's technically a breaking change so we should do a 4.0.0 bump, but I don't know if he has thoughts on that. We'd also want to get as many breaking changes together as we can before merging this.