Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PIPENV_SKIP_LOCK environment variable #4797

Merged
merged 3 commits into from
Feb 20, 2022
Merged

Conversation

ELHoussineT
Copy link
Contributor

@ELHoussineT ELHoussineT commented Sep 26, 2021

The issue

The value of PIPENV_SKIP_LOCK is always False. This has been discussed in previous issues (#2200 and #3332) with no resolution.

The fix

PIPENV_SKIP_LOCK to consider the value of the environment variable PIPENV_SKIP_LOCK.

This is useful to large project as it enables the environment variable PIPENV_SKIP_LOCK to control the locking behavior.

Default behavior is not changed, still False.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

This is useful to large project as it enables the environment variable `PIPENV_SKIP_LOCK` to control the locking behavior. 

Default behavior is not changed, still False.
@oz123 oz123 self-requested a review February 9, 2022 23:21
@oz123 oz123 self-assigned this Feb 9, 2022
@oz123 oz123 added Status: Accepted ✔️ This item has been reviewed and accepted. Status: Changes Requested This item is currently pending changes requested from the author. labels Feb 9, 2022
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ELHoussineT Can you please add a NEWS fragment?

@ELHoussineT
Copy link
Contributor Author

EWS fragment?

@oz123 News fragment added.

@oz123 oz123 removed the Status: Changes Requested This item is currently pending changes requested from the author. label Feb 13, 2022
@oz123 oz123 requested review from oz123 and abravalheri and removed request for abravalheri February 20, 2022 18:49
@oz123 oz123 merged commit 8753cee into pypa:main Feb 20, 2022
@ELHoussineT ELHoussineT deleted the patch-1 branch February 20, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted ✔️ This item has been reviewed and accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants