Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vistir dropping #5078

Merged
merged 7 commits into from
Apr 25, 2022
Merged

More vistir dropping #5078

merged 7 commits into from
Apr 25, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Apr 23, 2022

Moving to Python version 3.7+ allows us to remove more usage of vistir.
Eventually we can completely drop it, but I prefer doing this gradually instead of a giant PR.

Also, I am not done yet. Will add 2-3 more commits, and we'll continue chopping this vistir with b[i,y]te size steps.

Pun intended :-)

NamedTemporaryFile was introduced in Python 3.4.
We only support Python 3.7+, hence this goes away.
Earlier versions of Python had Mapping in ``collections``. All versions
after 3.4 moved Mapping to ``collections.abc``
Since we only support version 3.7+ we can drop this.
pathlib was introduced after Python3.5. We now only
support Python3.7+, hence we don't need compat here.
@oz123 oz123 requested a review from matteius April 23, 2022 13:11
This function is a nice to have alias for one line of code.
Also, it uses OrderedDict, which is no longer needed. `dict`s after
Python3.6 are guaranteed to be ordered (bonus: dict is faster than
ordered dict).

If we really want, we can also import it from zipp or python finder.
The former is simply a copy paste of `click.echo`.

Since `click` has a much larger user base, it is likely
to correct all bugs on all OSes faster.
@oz123 oz123 marked this pull request as ready for review April 23, 2022 23:07
@oz123
Copy link
Contributor Author

oz123 commented Apr 23, 2022

@matteius when (and if) merging, please do not squash the commits. Doing so will lead to losing of a lot of information found in the commit messages.

@matteius matteius merged commit 295fb30 into main Apr 25, 2022
@matteius matteius deleted the more-vistir-dropping branch April 25, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants