Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old way of generting requirements. #5200

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Conversation

matteius
Copy link
Member

@matteius matteius commented Jul 28, 2022

Thank you for contributing to Pipenv!

The issue

Remove the deprecated install -r command and simplify the CLI interface + logic.

Fixes: #5198

The fix

We have the pipenv requirements command now.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius added the Status: In Progress This item is in progress. label Jul 28, 2022
@matteius matteius removed the Status: In Progress This item is in progress. label Aug 2, 2022
@matteius matteius requested a review from oz123 August 5, 2022 22:50
@oz123 oz123 merged commit 49f1c42 into main Aug 6, 2022
@oz123 oz123 deleted the issue-5198-remove-old-r branch August 6, 2022 06:32
@EugeniuZ
Copy link

pipenv lock -r does variable substitution (as of 2022.8.5) while pipenv requirements does not. This is needed when including private pypi repos with credentials that are substituted by env variables.

@oz123
Copy link
Contributor

oz123 commented Aug 23, 2022

Can you please open a separate issue for that?

@EugeniuZ
Copy link

EugeniuZ commented Aug 23, 2022

#5033 and #5272 seem to be related

@matteius
Copy link
Member Author

@EugeniuZ Its actually #5272 -- 5033 should probably be closed (people were getting hung up on index restricted packages) and 5200 is this PR.

felixedel added a commit to bmwcarit/zubbi that referenced this pull request Oct 10, 2022
cakekoa added a commit to guardicore/monkey that referenced this pull request Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit to guardicore/monkey that referenced this pull request Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit to guardicore/monkey that referenced this pull request Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Feb 28, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this pull request Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
jeffwidman added a commit to dependabot/dependabot-core that referenced this pull request Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in #7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
jeffwidman added a commit to dependabot/dependabot-core that referenced this pull request Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in #7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
jeffwidman added a commit to dependabot/dependabot-core that referenced this pull request Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in #7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
jeffwidman added a commit to dependabot/dependabot-core that referenced this pull request Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in #7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
thatgeeman added a commit to thatgeeman/workflows that referenced this pull request Aug 19, 2023
pipenv==2022.8.5  # because of `lock -r` change in pypa/pipenv#5200
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…ot#7764)

In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in dependabot#7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
stefanfreitag added a commit to stefanfreitag/aws-cdk that referenced this pull request Dec 10, 2023
As part of the pipenv release 2022.8.13 the deprecated way of generating requirements "pipenv install -r" or "pipenv lock -r" has been removed in favor of the "pipenv requirements" command.

* [Reference to pipenv CHANGELOG](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md#2022813-2022-08-13)
* [Refernce to relevant pipenv pull request](pypa/pipenv#5200)

Fixes aws#28015 by implementing the proposed change.
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Dec 18, 2023
As part of the pipenv release 2022.8.13 the deprecated way of generating requirements ("pipenv install -r" or "pipenv lock -r") has been removed in favor of the "pipenv requirements" command.

See  #28015 for the motivation behind this change.

* [Reference to pipenv CHANGELOG](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md#2022813-2022-08-13)
* [Refernce to relevant pipenv pull request](pypa/pipenv#5200)

Closes #28015 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish removal of the install -r flag for generating requirements.txt
3 participants