Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple categories in exported requirements #5431

Merged
merged 9 commits into from
Oct 23, 2022

Conversation

dojutsu-user
Copy link
Contributor

Closes: #5397

This adds a category option to the requirements command. If specified a category, it will only generate the requirements of that category.

@dojutsu-user dojutsu-user marked this pull request as ready for review October 22, 2022 09:28
pipenv/cli/command.py Outdated Show resolved Hide resolved
@dojutsu-user dojutsu-user requested a review from matteius October 22, 2022 10:02
@dojutsu-user dojutsu-user requested a review from matteius October 22, 2022 10:10
@oz123
Copy link
Contributor

oz123 commented Oct 22, 2022

Awesome work! Can you add a news snippet?
Then we are ready to merge.

@dojutsu-user
Copy link
Contributor Author

Thank you @oz123 😄,

Can you add a news snippet?

I am not sure what is news snippet. Can you help me here.

@oz123
Copy link
Contributor

oz123 commented Oct 23, 2022

We use a tool called town crier to update the changelog for the releases .
If you check the directory news you'll see what are these snippets.
Every time the release is created the are removed, so you can also look at the history of this directory.
Hope this helps. Thanks again for your contribution!

@dojutsu-user
Copy link
Contributor Author

Thanks @oz123,
I have added news. Let me know if that requires some changes.

@oz123 oz123 merged commit 177d02a into pypa:main Oct 23, 2022
@dojutsu-user dojutsu-user deleted the add-cmd-option-category branch October 23, 2022 12:56
@dojutsu-user
Copy link
Contributor Author

Thanks For Merging @oz123.
Can you also add hacktoberfest-accepted label in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple categories in exported requirements
3 participants