Invoke the resolver in the same process as pipenv rather than utilzing subprocess. #5787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Completely trim down the conftest.py and remove uneeded arguments
** try to ensure the directory is totally unique for the test
** Realize that click's CliRunner is actually to blame and even says in the docs that its not thread safe.
** Convert away from using CliRunner (mostly) for some reason the
graph --reverse
test is a special beast with unicode characters and a sub-process in a sub-process, so just use CliRunner there only.The issue
In thinking more about the issue that arose with the resolver using a different python version, and modules maybe being out of scope, I began to wonder why we were kicking it off as a subprocess. This reduces the number of files we have to write and read back in as well as eliminate the sub-process that we simply were waiting for anyway.
The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.