New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check --unused #821

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@krismolendyke
Contributor

krismolendyke commented Oct 3, 2017

  • Add missing mapping file from vendored pipreqs to dist
  • Resolve non-stdlib package names using mapping file before checking PyPI
  • Do not lower needed package names after resolving them with pipreqs
@erinxocon

This comment has been minimized.

Show comment
Hide comment
@erinxocon

erinxocon Oct 4, 2017

Contributor

Thanks for the contribution @krismolendyke! Would it be possible to write a test for this?
I'm gonna let @kennethreitz push the all powerful merge button on this! :)

Contributor

erinxocon commented Oct 4, 2017

Thanks for the contribution @krismolendyke! Would it be possible to write a test for this?
I'm gonna let @kennethreitz push the all powerful merge button on this! :)

@krismolendyke

This comment has been minimized.

Show comment
Hide comment
@krismolendyke

krismolendyke Oct 4, 2017

Contributor

Absolutely. When I went looking for existing tests before I missed this. I'll update to prove this functionality.

Contributor

krismolendyke commented Oct 4, 2017

Absolutely. When I went looking for existing tests before I missed this. I'll update to prove this functionality.

@kennethreitz kennethreitz merged commit fa5b990 into pypa:master Oct 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krismolendyke krismolendyke deleted the krismolendyke:fix-check-unused branch Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment